Fix stack frame filtering to use exact path comparison#1152
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
- Changed from path.include?(__FILE__) to path == debugger_file - This prevents incorrectly filtering out application code that might have similar paths - More precise and robust filtering of debugger internal frames Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
- Move debugger file path to instance variable initialized once in constructor - Improve comment to explain specific scenario (substring matching issue) - Avoids repeated expensive File.expand_path calls on every stack frame update Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor DAP server based on review feedback
Fix stack frame filtering to use exact path comparison
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
update_stack_framesmethod filtered debugger frames usingpath.include?(__FILE__), which incorrectly filters application code when file paths contain the debugger path as a substring.Changes:
path == @debugger_fileFile.expand_path(__FILE__)as instance variable to avoid repeated filesystem callsBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.