New Debug Adapter Protocol (DAP) server#1145
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new Debug Adapter Protocol (DAP) server to replace the old custom debugger implementation. The DAP server enables debugging of RhoMobile applications through standard DAP-compatible clients like VS Code.
Changes:
- Complete rewrite of the debugger from a custom protocol to DAP-compliant implementation
- Added support for breakpoints, stepping, variable inspection, and stack traces via DAP protocol
- Added diagnostic logging in rhoframework.rb for debugging the debugger initialization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 27 comments.
| File | Description |
|---|---|
| lib/extensions/debugger/debugger.rb | Complete rewrite implementing DAP server with TCP socket handling, breakpoint management, and debug state tracking |
| lib/framework/rhoframework.rb | Added debug logging statement to verify debugger initialization parameters |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vmusulainen
changed the title
|
@vmusulainen I've opened a new pull request, #1146, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
|
@vmusulainen I've opened a new pull request, #1149, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
|
@vmusulainen I've opened a new pull request, #1150, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
|
@vmusulainen I've opened a new pull request, #1151, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@vmusulainen I've opened a new pull request, #1152, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@vmusulainen I've opened a new pull request, #1153, to work on those changes. Once the pull request is ready, I'll request review from you. |
Implement resource cleanup in DAP server disconnect handler
Add DEBUG_HOST validation to prevent debugger exposure to external networks
…hods Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
Co-authored-by: vmusulainen <143790+vmusulainen@users.noreply.github.com>
…8886-470c-b967-d8f10e48e945
…8886-470c-b967-d8f10e48e945 Add comprehensive documentation to DAPServer class
This pull request introduces a new Debug Adapter Protocol (DAP) server to replace the old custom debugger implementation. The DAP server enables debugging of RhoMobile applications through standard DAP-compatible clients like VS Code.
Changes:
Complete rewrite of the debugger from a custom protocol to DAP-compliant implementation
Added support for breakpoints, stepping, variable inspection, and stack traces via DAP protocol
Added diagnostic logging in rhoframework.rb for debugging the debugger initialization