Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to find a clean way to integrate new changes here... might have to start over #1

Open
wants to merge 18 commits into
base: test-updates-to-golang-with-rebase
Choose a base branch
from

Commits on Sep 12, 2023

  1. reapi: add Golang CLI bindings

    Go clients need to call REAPI CLI functions.
    
    Add Go bindings for REAPI CLI for resource module
    initialization, destruction, match allocate,
    cancel, and other common functions.
    cmisale authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4210f0a View commit details
    Browse the repository at this point in the history
  2. reapi: add Golang module bindings

    Go clients need to call REAPI module functions.
    
    Add Go bindings for REAPI module for resource module
    initialization, destruction, match allocate,
    cancel, and other common functions.
    cmisale authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a80d7f1 View commit details
    Browse the repository at this point in the history
  3. reapi: open Flux handle to init reapi_module_ctx_t

    Problem: the REAPI module assumes the resource module
    is already initialized but does not open a handle
    to it.
    
    Open a handle to make calls with a resource module
    instance.
    cmisale authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    53f7958 View commit details
    Browse the repository at this point in the history
  4. testsuite: add Golang client test

    Problem: the Golang bindings need to be tested
    as part of the Fluxion testsuite.
    
    Add a main Go test to initialize the resource module
    and output strings for comparison with expected
    outputs.
    cmisale authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1e42286 View commit details
    Browse the repository at this point in the history
  5. build: add golang to autotools

    Problem: the main test file must be
    built as part of the `make check` tests.
    
    Configure autotools to build main.go
    for sharness tests.
    milroy authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    65ca6d3 View commit details
    Browse the repository at this point in the history
  6. ci: add focal-golang to test matrix

    Problem: the test matrix does not have
    an image with Go installed.
    
    Create a new Docker image which installs
    Go and adds `go` to `PATH`. Add the image
    and additional tests to the CI test matrix.
    milroy authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    492f332 View commit details
    Browse the repository at this point in the history
  7. testsuite: add golang sharness tests

    Problem: the Fluxion sharness tests need to test the
    Golang bindings.
    
    Add a basic sharness test and expected outputs.
    milroy authored and vsoch committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f81137d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. reapi: updates for golang

    Problem: Go bindings can be more friendly to Go developers
    Solution: This includes docstring changes, the main module path
    to be under flux-framework, returning Go error instead of int,
    and updating tests to return nil (no error) instead of 0. The
    module path is fixed from a development variant to a
    flux-framework one. Finally, it fixes the Go bindings to
    use a struct instead of passing around a ctx variable. Our
    goal with these final changes to the Go module is to make
    the code more friendly to future go developers.
    
    Signed-off-by: vsoch <[email protected]>
    vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    75825be View commit details
    Browse the repository at this point in the history
  2. reapi: add Golang CLI bindings

    Go clients need to call REAPI CLI functions.
    
    Add Go bindings for REAPI CLI for resource module
    initialization, destruction, match allocate,
    cancel, and other common functions.
    cmisale authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7af64cd View commit details
    Browse the repository at this point in the history
  3. reapi: add Golang module bindings

    Go clients need to call REAPI module functions.
    
    Add Go bindings for REAPI module for resource module
    initialization, destruction, match allocate,
    cancel, and other common functions.
    cmisale authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    110f448 View commit details
    Browse the repository at this point in the history
  4. reapi: open Flux handle to init reapi_module_ctx_t

    Problem: the REAPI module assumes the resource module
    is already initialized but does not open a handle
    to it.
    
    Open a handle to make calls with a resource module
    instance.
    cmisale authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    234c489 View commit details
    Browse the repository at this point in the history
  5. testsuite: add Golang client test

    Problem: the Golang bindings need to be tested
    as part of the Fluxion testsuite.
    
    Add a main Go test to initialize the resource module
    and output strings for comparison with expected
    outputs.
    cmisale authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    28494a8 View commit details
    Browse the repository at this point in the history
  6. build: add golang to autotools

    Problem: the main test file must be
    built as part of the `make check` tests.
    
    Configure autotools to build main.go
    for sharness tests.
    milroy authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    7bc5116 View commit details
    Browse the repository at this point in the history
  7. ci: add focal-golang to test matrix

    Problem: the test matrix does not have
    an image with Go installed.
    
    Create a new Docker image which installs
    Go and adds `go` to `PATH`. Add the image
    and additional tests to the CI test matrix.
    milroy authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    a428d02 View commit details
    Browse the repository at this point in the history
  8. testsuite: add golang sharness tests

    Problem: the Fluxion sharness tests need to test the
    Golang bindings.
    
    Add a basic sharness test and expected outputs.
    milroy authored and vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bae2c20 View commit details
    Browse the repository at this point in the history
  9. reapi: updates for golang

    Problem: Go bindings can be more friendly to Go developers
    Solution: This includes docstring changes, the main module path
    to be under flux-framework, returning Go error instead of int,
    and updating tests to return nil (no error) instead of 0. The
    module path is fixed from a development variant to a
    flux-framework one. Finally, it fixes the Go bindings to
    use a struct instead of passing around a ctx variable. Our
    goal with these final changes to the Go module is to make
    the code more friendly to future go developers.
    
    Signed-off-by: vsoch <[email protected]>
    vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    644bd74 View commit details
    Browse the repository at this point in the history
  10. test: dockerfile updates for golang-focal for cmake

    Signed-off-by: vsoch <[email protected]>
    vsoch committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    25d9171 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6cba0a3 View commit details
    Browse the repository at this point in the history