-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to find a clean way to integrate new changes here... might have to start over #1
base: test-updates-to-golang-with-rebase
Are you sure you want to change the base?
Commits on Sep 12, 2023
-
reapi: add Golang CLI bindings
Go clients need to call REAPI CLI functions. Add Go bindings for REAPI CLI for resource module initialization, destruction, match allocate, cancel, and other common functions.
Configuration menu - View commit details
-
Copy full SHA for 4210f0a - Browse repository at this point
Copy the full SHA 4210f0aView commit details -
reapi: add Golang module bindings
Go clients need to call REAPI module functions. Add Go bindings for REAPI module for resource module initialization, destruction, match allocate, cancel, and other common functions.
Configuration menu - View commit details
-
Copy full SHA for a80d7f1 - Browse repository at this point
Copy the full SHA a80d7f1View commit details -
reapi: open Flux handle to init reapi_module_ctx_t
Problem: the REAPI module assumes the resource module is already initialized but does not open a handle to it. Open a handle to make calls with a resource module instance.
Configuration menu - View commit details
-
Copy full SHA for 53f7958 - Browse repository at this point
Copy the full SHA 53f7958View commit details -
testsuite: add Golang client test
Problem: the Golang bindings need to be tested as part of the Fluxion testsuite. Add a main Go test to initialize the resource module and output strings for comparison with expected outputs.
Configuration menu - View commit details
-
Copy full SHA for 1e42286 - Browse repository at this point
Copy the full SHA 1e42286View commit details -
build: add golang to autotools
Problem: the main test file must be built as part of the `make check` tests. Configure autotools to build main.go for sharness tests.
Configuration menu - View commit details
-
Copy full SHA for 65ca6d3 - Browse repository at this point
Copy the full SHA 65ca6d3View commit details -
ci: add focal-golang to test matrix
Problem: the test matrix does not have an image with Go installed. Create a new Docker image which installs Go and adds `go` to `PATH`. Add the image and additional tests to the CI test matrix.
Configuration menu - View commit details
-
Copy full SHA for 492f332 - Browse repository at this point
Copy the full SHA 492f332View commit details -
testsuite: add golang sharness tests
Problem: the Fluxion sharness tests need to test the Golang bindings. Add a basic sharness test and expected outputs.
Configuration menu - View commit details
-
Copy full SHA for f81137d - Browse repository at this point
Copy the full SHA f81137dView commit details
Commits on Sep 13, 2023
-
Problem: Go bindings can be more friendly to Go developers Solution: This includes docstring changes, the main module path to be under flux-framework, returning Go error instead of int, and updating tests to return nil (no error) instead of 0. The module path is fixed from a development variant to a flux-framework one. Finally, it fixes the Go bindings to use a struct instead of passing around a ctx variable. Our goal with these final changes to the Go module is to make the code more friendly to future go developers. Signed-off-by: vsoch <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 75825be - Browse repository at this point
Copy the full SHA 75825beView commit details -
reapi: add Golang CLI bindings
Go clients need to call REAPI CLI functions. Add Go bindings for REAPI CLI for resource module initialization, destruction, match allocate, cancel, and other common functions.
Configuration menu - View commit details
-
Copy full SHA for 7af64cd - Browse repository at this point
Copy the full SHA 7af64cdView commit details -
reapi: add Golang module bindings
Go clients need to call REAPI module functions. Add Go bindings for REAPI module for resource module initialization, destruction, match allocate, cancel, and other common functions.
Configuration menu - View commit details
-
Copy full SHA for 110f448 - Browse repository at this point
Copy the full SHA 110f448View commit details -
reapi: open Flux handle to init reapi_module_ctx_t
Problem: the REAPI module assumes the resource module is already initialized but does not open a handle to it. Open a handle to make calls with a resource module instance.
Configuration menu - View commit details
-
Copy full SHA for 234c489 - Browse repository at this point
Copy the full SHA 234c489View commit details -
testsuite: add Golang client test
Problem: the Golang bindings need to be tested as part of the Fluxion testsuite. Add a main Go test to initialize the resource module and output strings for comparison with expected outputs.
Configuration menu - View commit details
-
Copy full SHA for 28494a8 - Browse repository at this point
Copy the full SHA 28494a8View commit details -
build: add golang to autotools
Problem: the main test file must be built as part of the `make check` tests. Configure autotools to build main.go for sharness tests.
Configuration menu - View commit details
-
Copy full SHA for 7bc5116 - Browse repository at this point
Copy the full SHA 7bc5116View commit details -
ci: add focal-golang to test matrix
Problem: the test matrix does not have an image with Go installed. Create a new Docker image which installs Go and adds `go` to `PATH`. Add the image and additional tests to the CI test matrix.
Configuration menu - View commit details
-
Copy full SHA for a428d02 - Browse repository at this point
Copy the full SHA a428d02View commit details -
testsuite: add golang sharness tests
Problem: the Fluxion sharness tests need to test the Golang bindings. Add a basic sharness test and expected outputs.
Configuration menu - View commit details
-
Copy full SHA for bae2c20 - Browse repository at this point
Copy the full SHA bae2c20View commit details -
Problem: Go bindings can be more friendly to Go developers Solution: This includes docstring changes, the main module path to be under flux-framework, returning Go error instead of int, and updating tests to return nil (no error) instead of 0. The module path is fixed from a development variant to a flux-framework one. Finally, it fixes the Go bindings to use a struct instead of passing around a ctx variable. Our goal with these final changes to the Go module is to make the code more friendly to future go developers. Signed-off-by: vsoch <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 644bd74 - Browse repository at this point
Copy the full SHA 644bd74View commit details -
test: dockerfile updates for golang-focal for cmake
Signed-off-by: vsoch <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 25d9171 - Browse repository at this point
Copy the full SHA 25d9171View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cba0a3 - Browse repository at this point
Copy the full SHA 6cba0a3View commit details