Trying to find a clean way to integrate new changes here... might have to start over #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go clients need to call REAPI CLI functions. Add Go bindings for REAPI CLI for resource module initialization, destruction, match allocate, cancel, and other common functions.
Go clients need to call REAPI module functions. Add Go bindings for REAPI module for resource module initialization, destruction, match allocate, cancel, and other common functions.
Problem: the REAPI module assumes the resource module is already initialized but does not open a handle to it. Open a handle to make calls with a resource module instance.
Problem: the Golang bindings need to be tested as part of the Fluxion testsuite. Add a main Go test to initialize the resource module and output strings for comparison with expected outputs.
Problem: the main test file must be built as part of the `make check` tests. Configure autotools to build main.go for sharness tests.
Problem: the test matrix does not have an image with Go installed. Create a new Docker image which installs Go and adds `go` to `PATH`. Add the image and additional tests to the CI test matrix.
Problem: the Fluxion sharness tests need to test the Golang bindings. Add a basic sharness test and expected outputs.
Problem: Go bindings can be more friendly to Go developers Solution: This includes docstring changes, the main module path to be under flux-framework, returning Go error instead of int, and updating tests to return nil (no error) instead of 0. The module path is fixed from a development variant to a flux-framework one. Finally, it fixes the Go bindings to use a struct instead of passing around a ctx variable. Our goal with these final changes to the Go module is to make the code more friendly to future go developers. Signed-off-by: vsoch <[email protected]>
Go clients need to call REAPI CLI functions. Add Go bindings for REAPI CLI for resource module initialization, destruction, match allocate, cancel, and other common functions.
Go clients need to call REAPI module functions. Add Go bindings for REAPI module for resource module initialization, destruction, match allocate, cancel, and other common functions.
Problem: the REAPI module assumes the resource module is already initialized but does not open a handle to it. Open a handle to make calls with a resource module instance.
Problem: the Golang bindings need to be tested as part of the Fluxion testsuite. Add a main Go test to initialize the resource module and output strings for comparison with expected outputs.
Problem: the main test file must be built as part of the `make check` tests. Configure autotools to build main.go for sharness tests.
Problem: the test matrix does not have an image with Go installed. Create a new Docker image which installs Go and adds `go` to `PATH`. Add the image and additional tests to the CI test matrix.
Problem: the Fluxion sharness tests need to test the Golang bindings. Add a basic sharness test and expected outputs.
Problem: Go bindings can be more friendly to Go developers Solution: This includes docstring changes, the main module path to be under flux-framework, returning Go error instead of int, and updating tests to return nil (no error) instead of 0. The module path is fixed from a development variant to a flux-framework one. Finally, it fixes the Go bindings to use a struct instead of passing around a ctx variable. Our goal with these final changes to the Go module is to make the code more friendly to future go developers. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
vsoch
force-pushed
the
test-updates-to-golang-with-rebase
branch
11 times, most recently
from
80f9ffb
to
c056346
Compare
vsoch
force-pushed
the
test-updates-to-golang-with-rebase
branch
from
c056346
to
fb58ec0
Compare
vsoch
force-pushed
the
test-updates-to-golang-with-rebase
branch
3 times, most recently
from
95ee296
to
5704285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.