Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating unused arguments in connection pools's get_connection functions #3517

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

  • Adding deprecation annotations for unused arguments in connection pools's get_connection functions.
  • Adding a new decorator function that can be used to deprecate just input optional arguments for a function.
  • Updating all internal usages of get_connection functions not to provide any arguments.

@petyaslavova petyaslavova force-pushed the ps_deprecate_get_connection_with_unused_args branch from e132a1d to c455503 Compare February 19, 2025 13:24
@petyaslavova petyaslavova merged commit 8427c7b into master Feb 20, 2025
37 checks passed
@petyaslavova petyaslavova deleted the ps_deprecate_get_connection_with_unused_args branch February 20, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants