Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused arguments in the get_connection method in the ConnectionPool class #3007

Closed
nidemidovich opened this issue Oct 15, 2023 · 1 comment
Closed

Unused arguments in the get_connection method in the ConnectionPool class #3007

nidemidovich opened this issue Oct 15, 2023 · 1 comment

Comments

@nidemidovich
Copy link

Version: 5.0.1

Description:
It looks like the get_connection methods in the synchronous and asynchronous versions of ConnectionPool pass parameters that are not used there:

Should they really be there?
@petyaslavova
Copy link
Collaborator

Hi @nidemidovich, thanks for pointing this out!
The unused arguments have been marked as deprecated with PR #3517 and will be fully removed after a few releases.
I'm closing this issue now as it is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nidemidovich @petyaslavova