Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from main for ramen #358

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Commits on Sep 17, 2024

  1. go.mod: run go mod tidy

    k8s.io/component-base should have been a direct dependency.
    Fixes the go mod error.
    
    Signed-off-by: Raghavendra Talur <[email protected]>
    raghavendra-talur authored and ShyamsundarR committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    327011f View commit details
    Browse the repository at this point in the history
  2. Update Ramen to use latest CRD from external-snapshotter

    - Integrated the latest CRD from external-snapshotter.
    - Updated dependencies and relevant configuration files.
    - Changed VolumeSnapshotRefList in VolumeGroupSnapshotStatus to PVCVolumeSnapshotRefList,
    which allows to map a VolumeSnapshot to the application PVC.
    
    Signed-off-by: Benamar Mekhissi <[email protected]>
    Benamar Mekhissi authored and ShyamsundarR committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    33c8a2a View commit details
    Browse the repository at this point in the history
  3. Ensure VGS name contains at most 63 characters

    Signed-off-by: Benamar Mekhissi <[email protected]>
    Benamar Mekhissi authored and ShyamsundarR committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    10e34bc View commit details
    Browse the repository at this point in the history
  4. Ensure the Secondary VRG is updated when DRPC is updated

    This is mainly to ensure that the VRG on the primary and secondary are in sync
    in regards to labels and annotations
    
    Signed-off-by: Benamar Mekhissi <[email protected]>
    Benamar Mekhissi authored and ShyamsundarR committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c247950 View commit details
    Browse the repository at this point in the history
  5. Prepare for volsync block device test (RamenDR#1559)

    * Allow unprivileged pods to access block devices
    
    We need this for testing volsync with block devices with minikube
    clusters.
    
    For minikube clusters this is done via the environment file which is
    nicer, but it requires configuring containerd after the cluster has
    started, which can cause failures in addons scripts.
    
    We need to upstream this change to minikube later.
    
    Signed-off-by: Nir Soffer <[email protected]>
    
    * Log replication source status in yaml
    
    It is easier to read and works better for viewing the replication logs
    in the status.
    
    Signed-off-by: Nir Soffer <[email protected]>
    
    * Improve volsync test teardown
    
    - Delete the replication source before unexporting the volsync service
      using it.
    - Log every every teardown step to make debugging easier.
    
    Signed-off-by: Nir Soffer <[email protected]>
    
    * Fail if deleting destination namespace get stuck
    
    Replace delete used for waiting for waiting on the deleted namespace
    with a timeout. If deletion get stuck, the test will fail instead of
    blocking forever, breaking stress test.
    
    When delete get suck we can inspect the resources in the test gather
    directory:
    
        % tree out/013.gather/dr2/namespaces/busybox
        out/013.gather/dr2/namespaces/busybox
        └── snapshot.storage.k8s.io
            └── volumesnapshots
                └── volsync-busybox-dst-dst-20240914203905.yaml
    
        % cat out/013.gather/dr2/namespaces/busybox/snapshot.storage.k8s.io/volumesnapshots/volsync-busybox-dst-dst-20240914203905.yaml
        apiVersion: snapshot.storage.k8s.io/v1
        kind: VolumeSnapshot
        metadata:
          creationTimestamp: "2024-09-14T20:39:05Z"
          deletionGracePeriodSeconds: 0
          deletionTimestamp: "2024-09-14T20:39:05Z"
          finalizers:
          - snapshot.storage.kubernetes.io/volumesnapshot-bound-protection
          generation: 2
    
    This looks like an external-snapshotter bug since volsync deleted the
    snapshot and removed its finalizers.
    
    Signed-off-by: Nir Soffer <[email protected]>
    
    ---------
    
    Signed-off-by: Nir Soffer <[email protected]>
    nirs authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    566596f View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge pull request #357 from red-hat-storage/sync_us--main

    Syncing latest changes from upstream main for ramen
    ShyamsundarR authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6e8539a View commit details
    Browse the repository at this point in the history