Syncing latest changes from main for ramen #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s.io/component-base should have been a direct dependency. Fixes the go mod error. Signed-off-by: Raghavendra Talur <[email protected]>
- Integrated the latest CRD from external-snapshotter. - Updated dependencies and relevant configuration files. - Changed VolumeSnapshotRefList in VolumeGroupSnapshotStatus to PVCVolumeSnapshotRefList, which allows to map a VolumeSnapshot to the application PVC. Signed-off-by: Benamar Mekhissi <[email protected]>
Signed-off-by: Benamar Mekhissi <[email protected]>
This is mainly to ensure that the VRG on the primary and secondary are in sync in regards to labels and annotations Signed-off-by: Benamar Mekhissi <[email protected]>
* Allow unprivileged pods to access block devices We need this for testing volsync with block devices with minikube clusters. For minikube clusters this is done via the environment file which is nicer, but it requires configuring containerd after the cluster has started, which can cause failures in addons scripts. We need to upstream this change to minikube later. Signed-off-by: Nir Soffer <[email protected]> * Log replication source status in yaml It is easier to read and works better for viewing the replication logs in the status. Signed-off-by: Nir Soffer <[email protected]> * Improve volsync test teardown - Delete the replication source before unexporting the volsync service using it. - Log every every teardown step to make debugging easier. Signed-off-by: Nir Soffer <[email protected]> * Fail if deleting destination namespace get stuck Replace delete used for waiting for waiting on the deleted namespace with a timeout. If deletion get stuck, the test will fail instead of blocking forever, breaking stress test. When delete get suck we can inspect the resources in the test gather directory: % tree out/013.gather/dr2/namespaces/busybox out/013.gather/dr2/namespaces/busybox └── snapshot.storage.k8s.io └── volumesnapshots └── volsync-busybox-dst-dst-20240914203905.yaml % cat out/013.gather/dr2/namespaces/busybox/snapshot.storage.k8s.io/volumesnapshots/volsync-busybox-dst-dst-20240914203905.yaml apiVersion: snapshot.storage.k8s.io/v1 kind: VolumeSnapshot metadata: creationTimestamp: "2024-09-14T20:39:05Z" deletionGracePeriodSeconds: 0 deletionTimestamp: "2024-09-14T20:39:05Z" finalizers: - snapshot.storage.kubernetes.io/volumesnapshot-bound-protection generation: 2 This looks like an external-snapshotter bug since volsync deleted the snapshot and removed its finalizers. Signed-off-by: Nir Soffer <[email protected]> --------- Signed-off-by: Nir Soffer <[email protected]>
Syncing latest changes from upstream main for ramen
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from main branch