Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2313515: [release-4.17] remove resource limits on ocs-metrics-exporter #2814

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2813

/assign weirdwiz

removing the limits on ocs-metrics-exporter, the in memory cache scales
with the amount of PVs in the cluster making it hard to point out an
upper limit for the memory.

Signed-off-by: Divyansh Kamboj <[email protected]>
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: weirdwiz.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2813

/assign weirdwiz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weirdwiz
Copy link
Contributor

/retitle Bug 2313515: [release-4.17] remove resource limits on ocs-metrics-exporter

@openshift-ci openshift-ci bot changed the title [release-4.17] remove resource limits on ocs-metrics-exporter Bug 2313515: [release-4.17] remove resource limits on ocs-metrics-exporter Sep 20, 2024
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 20, 2024
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2313515, which is invalid:

  • expected the bug to target the "ODF 4.17.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2313515: [release-4.17] remove resource limits on ocs-metrics-exporter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 20, 2024
@weirdwiz
Copy link
Contributor

weirdwiz commented Sep 20, 2024

/bugzilla refresh

1 similar comment
@weirdwiz
Copy link
Contributor

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 20, 2024
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@weirdwiz: This pull request references Bugzilla bug 2313515, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 20, 2024
@weirdwiz
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2099477 into red-hat-storage:release-4.17 Sep 23, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2313515 has been moved to the MODIFIED state.

In response to this:

Bug 2313515: [release-4.17] remove resource limits on ocs-metrics-exporter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants