Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2313515: Revert "Merge pull request #2679 from umangachapagain/metrics-secure" #2835

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

weirdwiz
Copy link
Contributor

@weirdwiz weirdwiz commented Oct 3, 2024

This reverts commit dfffbde, reversing changes made to 88b5d23.

@weirdwiz weirdwiz force-pushed the revert branch 2 times, most recently from 1869e48 to 807a859 Compare October 3, 2024 09:39
…metrics-secure"

This reverts commit dfffbde, reversing
changes made to 88b5d23.

Signed-off-by: Divyansh Kamboj <[email protected]>
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@weirdwiz weirdwiz changed the base branch from main to release-4.17 October 4, 2024 07:56
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@weirdwiz: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Revert "Merge pull request #2679 from umangachapagain/metrics-secure"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@weirdwiz
Copy link
Contributor Author

weirdwiz commented Oct 4, 2024

/retest

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@weirdwiz
Copy link
Contributor Author

weirdwiz commented Oct 4, 2024

/test ocs-operator-bundle-e2e-aws

@weirdwiz
Copy link
Contributor Author

weirdwiz commented Oct 4, 2024

/retest

@agarwal-mudit agarwal-mudit changed the title Revert "Merge pull request #2679 from umangachapagain/metrics-secure" Bug 2313515: Revert "Merge pull request #2679 from umangachapagain/metrics-secure" Oct 4, 2024
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@weirdwiz: This pull request references Bugzilla bug 2313515, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2313515: Revert "Merge pull request #2679 from umangachapagain/metrics-secure"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 4, 2024
@agarwal-mudit
Copy link
Member

/bugzilla refresh

Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@agarwal-mudit: This pull request references Bugzilla bug 2313515, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.17.0) matches configured target release for branch (ODF 4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agarwal-mudit agarwal-mudit added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2024
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 281a035 into red-hat-storage:release-4.17 Oct 4, 2024
5 checks passed
Copy link
Contributor

openshift-ci bot commented Oct 4, 2024

@weirdwiz: All pull requests linked via external trackers have merged:

Bugzilla bug 2313515 has been moved to the MODIFIED state.

In response to this:

Bug 2313515: Revert "Merge pull request #2679 from umangachapagain/metrics-secure"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants