Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for kubernetes-csi-addons #232

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

this commit updates the volumereplication conditions to
include descriptive message for every
operations

Signed-off-by: yati1998 <[email protected]>
@df-build-team df-build-team requested a review from a team November 9, 2024 08:05
dependabot bot and others added 3 commits November 12, 2024 08:04
Bumps the golang-dependencies group with 1 update: [google.golang.org/grpc](https://github.com/grpc/grpc-go).

Updates `google.golang.org/grpc` from 1.67.1 to 1.68.0
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.67.1...v1.68.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Praveen M <[email protected]>
as its been 2 years to support legacy
endpoint, lets remove the support for it.

Signed-off-by: Madhu Rajanna <[email protected]>
In the connection pool we store the connection
with unique identifier, the pod name and the
namespace is used as the key to the connection
in the pool and GetLeaderByDriver get the leader
based on the driver name and uses the identity
of the leader which is pod name as the key to
get the connection.

Signed-off-by: Madhu Rajanna <[email protected]>
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 13, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f1f9821 into main Nov 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants