Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSREG2] Upgrade "revision.c" to Git from SVN #1

Conversation

SergeGautherie
Copy link
Contributor

@SergeGautherie SergeGautherie commented May 28, 2018

Fixes

echo 'const int SVNRev = ' > revision.c
LC_ALL=C LANG=C svn info | grep Revision | cut -f 2 -d " " >> revision.c
svn: E155007: '/home/appveyor/sysreg2_workdir' is not a working copy
echo ';' >> revision.c
gcc -I/usr/include/libvirt/ -I/usr/include/libxml2/ -g -O0 -std=c99 -D_GNU_SOURCE -Wall -Wextra -c revision.c -o revision.o
revision.c:2:1: error: expected expression before ‘;’ token
;
^
makefile:26: recipe for target 'revision.o' failed
make: *** [revision.o] Error 1

--

Result example:
sysreg2 65d7945 starting


Obviously, creating at least 1 tag in Git would be interesting...

@SergeGautherie SergeGautherie force-pushed the SergeGautherie/PRonly_revision-c_SVN2Git branch from e071d7b to 5d92ad6 Compare May 29, 2018 12:52
@SergeGautherie SergeGautherie changed the title Upgrade "revision.c" to Git from SVN [SYSREG2] Upgrade "revision.c" to Git from SVN May 29, 2018
@ColinFinck ColinFinck merged commit ad5d3ed into reactos:master Jun 28, 2018
@SergeGautherie SergeGautherie deleted the SergeGautherie/PRonly_revision-c_SVN2Git branch June 28, 2018 20:13
@SergeGautherie
Copy link
Contributor Author

Thanks @ColinFinck.
Please, check why your commit did not use my public email address.

@learn-more
Copy link
Member

Probably because they used the website squash feature, and then it uses the public email from your profile (which is none, hence the noreply)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants