Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSREG2] makefile: improve revision.c and virt.cpp #4

Conversation

SergeGautherie
Copy link
Contributor

  • makefile: Move 'rm revision.c' to 'clean' target
    And add '/revision.c' to '.gitignore'.

This makes it easy to check revision.c content.
And seems more consistent to me.

--

  • Rename 'virt.cpp' to 'sysreg2.cpp'

Let us be explicit and not confuse with 'libvirt.cpp'.

- And add '/revision.c' to '.gitignore'.

This makes it easy to check revision.c content.
Let us be explicit and not confuse with 'libvirt.cpp'.
@HeisSpiter
Copy link
Member

I don't see the point of this pull request and this changes.
Can you explain before I close? What are you trying to achieve?

@SergeGautherie
Copy link
Contributor Author

Can you explain before I close? What are you trying to achieve?

I am not sure what I could add to what I already wrote...

These are two points I noticed when I started to look at this code:

@HeisSpiter
Copy link
Member

Closing, given it provides no clear improvement.

@HeisSpiter HeisSpiter closed this Dec 26, 2018
@SergeGautherie SergeGautherie deleted the SergeGautherie/PRonly_makefile_revision-virt branch December 27, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants