-
Notifications
You must be signed in to change notification settings - Fork 12
Rebasing #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balasaraswathy-n
wants to merge
18
commits into
topic/increase_pid_limit
Choose a base branch
from
develop
base: topic/increase_pid_limit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebasing #296
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b2cb998
Adding changelog
7ad16f5
Merge branch 'develop' into release/1.11.0
divyang-public b8bc2d9
Merge pull request #290 from rdkcentral/release/1.11.0
rdkcm-rdke 95412cc
RDKEMW-8528: Remove logMilestone.sh & use Binary implementation (#268)
dshett549 6872de1
RDKEMW-8528: Avoiding cimplog to install onboarding_log bin (#297)
dshett549 3696e6a
RDKEMW-8528 : Remove logMilestone.sh installation from rdk-logger (#304)
dshett549 3b5203d
Revert "RDKEMW-8528: Remove logMilestone.sh installation from rdk-log…
karuna2git 88eb5dc
RDKEMW-3485: Add validate_pr_desc.ym; (#301)
ssitar583 c8e7dad
RDKEMW-9549 : Revert "RDKEMW-8528: Remove logMilestone.sh & use Bina…
karuna2git bd93b43
RDKE-900: Default to MTLS connection on all endpoints (#276)
MonekaLakshmi 04dbdb8
RDKEMW-6715: [RDKE]AUTOREV in Middleware layer components (#262)
melhar098 719e11f
Adding changelog
54cc48a
RDKEMW-9590: Rebase branch with 'develop' (#317)
divyang-public 0cbf5a6
Merge pull request #318 from rdkcentral/develop
divyang-public d644940
Merge pull request #316 from rdkcentral/release/1.12.0
rdkcm-rdke bafd64c
RDKEMW-9849: Move memcapture to middleware layer
naveenkumarhanasi 461823f
Update memcapture_git.bb
nhanasi 4aeaf6f
Merge pull request #321 from rdkcentral/feature/RDKEMW-9849
nhanasi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| name: PR Description Validation | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [develop] | ||
| types: [opened, edited, synchronize] | ||
|
|
||
| jobs: | ||
| validate-pr-description: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Validate PR Description | ||
| env: | ||
| PR_TITLE: ${{ github.event.pull_request.title }} | ||
| PR_BODY: ${{ github.event.pull_request.body }} | ||
| run: | | ||
| # Define valid ticket IDs | ||
| VALID_TICKET_IDS=("RDKEMW" "RDKEVD" "IMMUI" "RDK") | ||
| # Function to validate ticket format and ID | ||
| validate_ticket() { | ||
| local text="$1" | ||
| local field_name="$2" | ||
| echo "Validating $field_name: $text" | ||
| # Check if text matches the pattern <TICKETID>-<ticketno.> : <desc> | ||
| if [[ ! "$text" =~ ^[A-Z0-9]+-[0-9]+[[:space:]]*:[[:space:]]*.+ ]]; then | ||
| echo "ERROR: $field_name format is invalid." | ||
| echo "Expected format: <TICKETID>-<ticketno.> : <description>" | ||
| echo "Example: RDKEMW-123 : Fix playbook issue" | ||
| echo "" | ||
| echo "Valid ticket IDs are:" | ||
| printf "%s\n" "${VALID_TICKET_IDS[@]}" | ||
| return 1 | ||
| fi | ||
| # Extract ticket ID from the text | ||
| local ticket_prefix=$(echo "$text" | sed -n 's/^\([A-Z0-9]\+\)-[0-9]\+[[:space:]]*:.*$/\1/p') | ||
| if [ -z "$ticket_prefix" ]; then | ||
| echo "ERROR: Could not extract ticket ID from $field_name." | ||
| echo "Expected format: <TICKETID>-<ticketno.> : <description>" | ||
| echo "" | ||
| echo "Valid ticket IDs are:" | ||
| printf "%s\n" "${VALID_TICKET_IDS[@]}" | ||
| return 1 | ||
| fi | ||
| # Check if extracted ticket ID is in the valid list | ||
| local valid=false | ||
| for valid_id in "${VALID_TICKET_IDS[@]}"; do | ||
| if [ "$ticket_prefix" = "$valid_id" ]; then | ||
| valid=true | ||
| break | ||
| fi | ||
| done | ||
| if [ "$valid" = false ]; then | ||
| echo "ERROR: Invalid ticket ID '$ticket_prefix' in $field_name" | ||
| echo "" | ||
| echo "Valid ticket IDs are:" | ||
| printf "%s\n" "${VALID_TICKET_IDS[@]}" | ||
| echo "" | ||
| echo "Your $field_name should start with one of the above ticket IDs followed by a number." | ||
| echo "Example: RDKEMW-123 : Fix playbook issue" | ||
| return 1 | ||
| fi | ||
| echo "$field_name validation passed! Ticket ID: $ticket_prefix" | ||
| return 0 | ||
| } | ||
| # Track validation results | ||
| TITLE_VALID=true | ||
| DESCRIPTION_VALID=true | ||
| # Validate PR Title | ||
| echo "=== Validating PR Title ===" | ||
| if ! validate_ticket "$PR_TITLE" "PR title"; then | ||
| TITLE_VALID=false | ||
| fi | ||
| echo "" | ||
| echo "=== Validating PR Description ===" | ||
| # Validate PR Description | ||
| if [ -n "$PR_BODY" ]; then | ||
| if ! validate_ticket "$PR_BODY" "PR description"; then | ||
| DESCRIPTION_VALID=false | ||
| fi | ||
| else | ||
| echo "ERROR: PR description is empty." | ||
| echo "Both PR title and description must contain valid ticket IDs." | ||
| DESCRIPTION_VALID=false | ||
| fi | ||
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | ||
| echo "PR Description: $([ "$DESCRIPTION_VALID" = true ] && echo "PASSED" || echo "FAILED")" | ||
| # Exit with error if either validation failed | ||
| if [ "$TITLE_VALID" = false ] || [ "$DESCRIPTION_VALID" = false ]; then | ||
| echo "" | ||
| echo "VALIDATION FAILED: Both PR title and description must contain valid ticket IDs from the approved list: ${VALID_TICKET_IDS[@]}" | ||
| exit 1 | ||
| fi | ||
| echo "" | ||
| echo "ALL VALIDATIONS PASSED! Both PR title and description contain valid ticket IDs." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,15 +3,14 @@ SECTION = "console/utils" | |||||
|
|
||||||
| LICENSE = "Apache-2.0" | ||||||
| LIC_FILES_CHKSUM = "file://LICENSE;md5=175792518e4ac015ab6696d16c4f607e" | ||||||
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||||||
| PV = "2.0.0" | ||||||
| PR = "r0" | ||||||
|
|
||||||
| SRCREV = "0087a47dbc6c28905f7fd4424a43ed1fc8874389" | ||||||
|
|
||||||
| SRC_URI = "${CMF_GITHUB_ROOT}/rdk_logger;protocol=https;branch=main" | ||||||
|
|
||||||
| S = "${WORKDIR}/git" | ||||||
| SRCREV = "v2.3.0" | ||||||
|
||||||
| SRCREV = "v2.3.0" | |
| SRCREV = "abcdef1234567890abcdef1234567890abcdef12" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| SUMMARY = "Memcapture - memory reporting and analysis tool for RDK" | ||
| DESCRIPTION = "A C++ tool to capture the average memory usage of a platform including per-process memory usage and data metrics present them in a report" | ||
|
|
||
| LICENSE = "Apache-2.0" | ||
|
|
||
| LIC_FILES_CHKSUM = "file://${WORKDIR}/git/LICENSE;md5=1b8525f92b462b86205ffaba159b4481" | ||
|
|
||
| SRC_URI = "git://github.com/RDKCentral/MemCapture.git;branch=main;name=src;destsuffix=git" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| B = "${WORKDIR}/build" | ||
|
|
||
| DEPENDS = "inja nlohmann-json" | ||
|
|
||
| inherit cmake syslog-ng-config-gen systemd | ||
| EXTRA_OECMAKE += "-DCMAKE_BUILD_TYPE=Release" | ||
| EXTRA_OECMAKE += "${@bb.utils.contains('DISTRO_FEATURES', 'disable_idle_metrics', '-DENABLE_CPU_IDLE_METRICS=OFF', '-DENABLE_CPU_IDLE_METRICS=ON', d)}" | ||
|
|
||
| SYSLOG-NG_FILTER = "memcapture" | ||
| SYSLOG-NG_SERVICE_memcapture = "memcapture.service" | ||
| SYSLOG-NG_DESTINATION_memcapture = "memcapture.log" | ||
| SYSLOG-NG_LOGRATE_memcapture = "high" | ||
|
|
||
| do_install () { | ||
| install -d ${D}${bindir} | ||
| install -m 4755 ${B}/MemCapture ${D}${bindir} | ||
| } | ||
|
|
||
| FILES:${PN} += "${bindir}/MemCapture \ | ||
| " |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in output messages. Line 102 has an extra space before 'FAILED' (' FAILED') while line 103 correctly has no extra space ('FAILED'). This inconsistency should be corrected for uniform output formatting.