-
Notifications
You must be signed in to change notification settings - Fork 12
Rebasing #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/increase_pid_limit
Are you sure you want to change the base?
Rebasing #296
Conversation
RDKEMW-8494: Back-merge release branch to develop
Reason for change: For optimization Test Procedure: Tested and verified Risks:Medium Priority:P1
|
svc_rdkgerrit02 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Reason for change: Avoiding cimplog to install onboarding_log bin which is already installed by rdklogger Test Procedure: Tested and verified Risks:Medium Priority:P0
Reason for change: Remove logMilestone.sh installation from rdk-logger Test Procedure: Build for XIONE with wpe-2.46 enabled Risks: Low
Co-authored-by: Anand Kandasamy <[email protected]>
…y implementation (#268)" (#309) * Revert "RDKEMW-8528: Remove logMilestone.sh & use Binary implementation (#268)" This reverts commit 95412cc. * Update rdk-logger_git.bb * Update rdk-logger_git.bb --------- Co-authored-by: Anooj Cherian K <[email protected]>
Reason for change: Added CFLAG to enable MTLS for T2 Test Procedure: Make sure all communication is MTLS & secure Risks: Medium Priority: P1
Reason for change: Replacing AUTOREV with latest githashes Test Procedure: see ticket Risks: None Priority: P0 Signed-off-by: melhar098_comcast <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR performs a rebase operation, primarily updating SRCREV values to pin specific git commits instead of using AUTOREV, adding a new GitHub workflow for PR validation, and updating the CHANGELOG.
- Removes conditional feature flags for onboard logging support from cimplog recipe
- Pins multiple recipe dependencies to specific git commits instead of using AUTOREV
- Adds new GitHub Actions workflow to validate PR title and description format
- Updates CHANGELOG with version 1.11.0 release notes
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes-support/cimplog/cimplog_1.0.bb | Removes conditional compilation flags for FEATURE_SUPPORT_ONBOARD_LOGGING |
| recipes-containers/lxccpid/lxccpid_git.bb | Pins SRCREV to specific commit hash |
| recipes-common/telemetry/telemetry_git.bb | Adds -DENABLE_MTLS flag to CFLAGS |
| recipes-common/sys_mon_tools/sys_mon_tools.inc | Pins SRCREV to specific commit hash |
| recipes-common/sys_mon_tools/cpuprocanalyzer_git.bb | Pins SRCREV to specific commit hash |
| recipes-common/rdk-logger/rdk-logger_git.bb | Updates to version 2.3.0 and reorders metadata fields |
| recipes-common/dcm/dcmjsonparser_git.bb | Pins SRCREV to specific commit hash |
| recipes-common/dca/dca_git.bb | Pins SRCREV to specific commit hash |
| CHANGELOG.md | Adds version 1.11.0 release notes with associated PRs and commits |
| .github/workflows/validate_pr_desc.yml | Introduces workflow to validate PR titles and descriptions against ticket ID format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SRC_URI = "${CMF_GITHUB_ROOT}/rdk_logger;protocol=https;branch=main" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| SRCREV = "v2.3.0" |
Copilot
AI
Oct 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SRCREV should reference a commit hash, not a tag name. Using 'v2.3.0' as SRCREV may cause build failures. Either fetch the actual commit hash that the tag points to, or if tags must be used, ensure the recipe is configured to handle tag references properly.
| SRCREV = "v2.3.0" | |
| SRCREV = "abcdef1234567890abcdef1234567890abcdef12" |
* RDKEMW-8528 : Remove logMilestone.sh installation from rdk-logger (#304) Reason for change: Remove logMilestone.sh installation from rdk-logger Test Procedure: Build for XIONE with wpe-2.46 enabled Risks: Low * Revert "RDKEMW-8528: Remove logMilestone.sh installation from rdk-logger" (#306) * Revert "RDKEMW-8528 : Remove logMilestone.sh installation from rdk-logger (#304)" This reverts commit 3696e6a. * RDKEMW-3485: Add validate_pr_desc.ym; (#301) Co-authored-by: Anand Kandasamy <[email protected]> * RDKE-900: Default to MTLS connection on all endpoints (#276) Reason for change: Added CFLAG to enable MTLS for T2 Test Procedure: Make sure all communication is MTLS & secure Risks: Medium Priority: P1 * RDKEMW-6715: [RDKE]AUTOREV in Middleware layer components (#262) Reason for change: Replacing AUTOREV with latest githashes Test Procedure: see ticket Risks: None Priority: P0 Signed-off-by: melhar098_comcast <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]> --------- Signed-off-by: melhar098_comcast <[email protected]> Co-authored-by: Deepthi C Shetty <[email protected]> Co-authored-by: Karunakaran A <[email protected]> Co-authored-by: ssitar583 <[email protected]> Co-authored-by: Anand Kandasamy <[email protected]> Co-authored-by: MonekaLakshmi <[email protected]> Co-authored-by: Mahmoud El-haron <[email protected]>
RDKEMW-9590: Rebase branch with 'develop'
RDKEMW-9590: Backmerge Release Branch to 'develop' for MW 8.4.1.0
Recipe add memcapture to middleware layer
RDKEMW-9849: Move memcapture to middleware layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "" | ||
| echo "=== Validation Summary ===" | ||
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent spacing in output messages. Line 102 has an extra space before 'FAILED' (' FAILED') while line 103 correctly has no extra space ('FAILED'). This inconsistency should be corrected for uniform output formatting.
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")" | |
| echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo "FAILED")" |
Rebase branch