docs: fix factual errors in multi-agent example page - #1813
Open
Shi-Dong wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes factual errors in
docs/examples/multi-agent.mdfound during a fact-check of every page underdocs/examples/against the actual code inexamples/multi_agent/.agent_system.py: run_agent_system→solver_worker/rewrite_worker/SelectorAgent). Intro, walkthrough, and variations rewritten to match.MAX_TURNSknob (MULTI_AGENT_CONFIGShas no such key);num_parallelis the number of concurrent solver/rewriter attempts per prompt, not a turn count.multi_agent/*andloss_mask/role_splitmetrics. Replaced with the real ones (rollout/raw_reward,perf/rollout_time, standard step-line metrics) plus how rewards are scaled bycorrect_reward_weight/incorrect_reward_weight.MAX_TURNSreplaced with real failure modes (rewriter template strength inprompts.py, deepscaler RM needing a boxed answer, sequential solver→rewriter→selector round-trips).call_roleparameter; rewritten in terms of making the solver/rewriter workers VLM-aware.Test plan
examples/multi_agent/agent_system.py,prompts.py, androllout_with_multi_agents.pyon current main