Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New make_linter_from_xpath() #2126

Merged
merged 8 commits into from
Sep 9, 2023
Merged

New make_linter_from_xpath() #2126

merged 8 commits into from
Sep 9, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #2064

As a follow-up I'll take a pass at converting any linters we have that can be generated with this new function. That will serve as another series of tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Merging #2126 (23ce3ae) into main (33335e8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 23ce3ae differs from pull request most recent head 279af24. Consider uploading reports for the commit 279af24 to get more accurate results

@@           Coverage Diff           @@
##             main    #2126   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         120      121    +1     
  Lines        5216     5232   +16     
=======================================
+ Hits         5198     5214   +16     
  Misses         18       18           
Files Changed Coverage Δ
R/make_linter_from_xpath.R 100.00% <100.00%> (ø)

@IndrajeetPatil IndrajeetPatil merged commit 2a94dab into main Sep 9, 2023
@IndrajeetPatil IndrajeetPatil deleted the make-linter-from-xpath branch September 9, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export a make_linter_from_xpath() helper?
4 participants