Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use make_linter_from_xpath() to generate simple linters #2128

Merged
merged 17 commits into from
Sep 10, 2023
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Follow-up to #2126 to demonstrate utility within our suite.

@MichaelChirico MichaelChirico marked this pull request as draft September 9, 2023 04:51
@MichaelChirico
Copy link
Collaborator Author

Draft while #2126 is pending since the diff base is unclear --> harder to review

'utils.R'
'aaa.R'
'AAA.R'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhat surprisingly roxygen2 uses C sorting -> aaa.R was coming after T_and_F_symbol_linter.R, which seems unintentional. Hence the name change.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2023

Codecov Report

Merging #2128 (7a6b466) into main (4a42798) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 7a6b466 differs from pull request most recent head 4cc66ec. Consider uploading reports for the commit 4cc66ec to get more accurate results

@@            Coverage Diff             @@
##             main    #2128      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files         121      111      -10     
  Lines        5260     5097     -163     
==========================================
- Hits         5242     5079     -163     
  Misses         18       18              

see 9 files with indirect coverage changes

@MichaelChirico MichaelChirico marked this pull request as ready for review September 9, 2023 14:51
@AshesITR AshesITR merged commit 02f7db8 into main Sep 10, 2023
@AshesITR AshesITR deleted the use-make-linter branch September 10, 2023 07:03
@IndrajeetPatil
Copy link
Collaborator

So cool!!

Thanks for introducing this helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants