-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re: Issue #147 #164
Open
obicons
wants to merge
2
commits into
quicklisp:master
Choose a base branch
from
obicons:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Re: Issue #147 #164
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,9 @@ | |
(defun system-list () | ||
(provided-systems t)) | ||
|
||
(defun all-installed-systems () | ||
(filter #'installedp (system-list))) | ||
|
||
(defun update-dist (dist &key (prompt t)) | ||
(when (stringp dist) | ||
(setf dist (find-dist dist))) | ||
|
@@ -77,13 +80,50 @@ | |
(defun help () | ||
"For help with Quicklisp, see http://www.quicklisp.org/beta/") | ||
|
||
(defun uninstall (system-name) | ||
(defun uninstall (systems &key remove-dependencies) | ||
(unless (consp systems) | ||
(setf systems (list systems))) | ||
(dolist (system-name systems systems) | ||
(let ((system (find-system system-name))) | ||
(cond ((and system remove-dependencies) | ||
(uninstall-system-dependencies system-name)) | ||
(system | ||
(ql-dist:uninstall system)) | ||
(t | ||
(warn "Unknown system ~S" system-name) | ||
nil))))) | ||
|
||
(defun uninstall-system-dependencies (system-name) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer to see this factored out a bit to produce the list of candidates to uninstall without actually uninstalling them. That will make it easier to test. |
||
"Uninstalls the dependencies of system-name." | ||
(when (symbolp system-name) | ||
(setf system-name (string-downcase (symbol-name system-name)))) | ||
(let ((system (find-system system-name))) | ||
(cond (system | ||
(ql-dist:uninstall system)) | ||
(cond ((not system) | ||
(warn "Unknown system ~S" system-name)) | ||
((not (installedp system)) | ||
(warn "System ~S is not installed" system-name)) | ||
(t | ||
(warn "Unknown system ~S" system-name) | ||
nil)))) | ||
;; consider the set X of `system` dependencies | ||
;; if any piece of installed software depends on a member of this set | ||
;; and is not a member of X, then we cannot delete that member | ||
(let* ((system-dependencies (remove-duplicates (mapcar #'name (flatten (dependency-tree system))) :test #'string=)) | ||
(installed-systems (all-installed-systems)) | ||
(all-other-dependencies | ||
(remove-duplicates | ||
(flatten (mapcar #'required-systems | ||
(filter | ||
#'(lambda (system) | ||
(not (member (name system) | ||
(cons system-name system-dependencies) | ||
:test #'string=))) | ||
installed-systems))) | ||
:test #'string=))) | ||
(dolist (system system-dependencies) | ||
(unless (member system all-other-dependencies :test #'string=) | ||
(format t "To uninstall: ~S~%" system) | ||
(ql-dist:uninstall (find-system system)) | ||
(finish-output))) | ||
(ql-dist:uninstall system)))))) | ||
|
||
(defun uninstall-dist (name) | ||
(let ((dist (find-dist name))) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think FILTER is a good utility function name. I'd prefer to stick with the built-in REMOVE-IF-NOT (which is also not a great name).