Re: Issue #147 #164
Re: Issue #147 #164
Conversation
…dencies of a package should be removed if they are no longer required. Modified `uninstall` to support multiple system deletes at once.
quicklisp/client.lisp
Outdated
| @@ -48,6 +48,9 @@ | |||
| (defun system-list () | |||
| (provided-systems t)) | |||
|
|
|||
| (defun all-installed-systems () | |||
| (filter #'installedp (system-list))) | |||
There was a problem hiding this comment.
I don't think FILTER is a good utility function name. I'd prefer to stick with the built-in REMOVE-IF-NOT (which is also not a great name).
quicklisp/client.lisp
Outdated
| (warn "Unknown system ~S" system-name) | ||
| nil))))) | ||
|
|
||
| (defun uninstall-system-dependencies (system-name) |
There was a problem hiding this comment.
I'd prefer to see this factored out a bit to produce the list of candidates to uninstall without actually uninstalling them. That will make it easier to test.
* General refactor to improve discoverability
|
Thanks for the quick review! I went ahead and did some refactoring to try and address your comments, specifically by removing the call and definition of To test this, I installed the modified client in a container. Then, I loaded two systems that share several dependencies (caveman and drakma) and verified that uninstalling one left the dependencies of the other intact. Let me know if you have any other comments/concerns 👍 |
UNINSTALLcan now accept a list of systems to removeUNINSTALLcan now optionally and safely remove a system's dependencies