Skip to content

Add support for creating ROCm docker image for torchtitan & enable ROCm CI support. #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

akashveramd
Copy link

@akashveramd akashveramd commented Jun 4, 2025

In this PR-

  • Added support for creating ROCm docker image for torchtian and running torchtitan tests on ROCm.
  • Added ROCm CI support for integration_test unit test.

@facebook-github-bot
Copy link

Hi @akashveramd!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@akashveramd akashveramd changed the title Added support to run torchtitan tests on ROCm. Added support for creating ROCm docker image for torchtian & run torchtitan tests on ROCm. Jun 4, 2025
@akashveramd akashveramd marked this pull request as draft June 4, 2025 05:45
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 5, 2025
@akashveramd akashveramd changed the title Added support for creating ROCm docker image for torchtian & run torchtitan tests on ROCm. Added support for creating ROCm docker image for torchtitan & run torchtitan tests on ROCm. Jun 12, 2025
@akashveramd akashveramd changed the title Added support for creating ROCm docker image for torchtitan & run torchtitan tests on ROCm. Add support for creating ROCm docker image for torchtitan & run torchtitan tests on ROCm. Jun 12, 2025
@akashveramd akashveramd force-pushed the torchtitan_rocm_support_main branch from ebaafdc to ce60b15 Compare June 12, 2025 07:32
@akashveramd akashveramd changed the title Add support for creating ROCm docker image for torchtitan & run torchtitan tests on ROCm. Add support for creating ROCm docker image for torchtitan & enable ROCm CI support. Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. module: rocm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants