Skip to content

Commit ebaafdc

Browse files
committed
Disabled failing tests in integration_tests.py for ROCm.
1 parent 573f426 commit ebaafdc

File tree

1 file changed

+46
-32
lines changed

1 file changed

+46
-32
lines changed

tests/integration_tests.py

Lines changed: 46 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
except ModuleNotFoundError:
2121
import tomli as tomllib
2222

23+
test_with_rocm = os.getenv("TEST_WITH_ROCM", "0")
24+
2325

2426
@dataclass
2527
class OverrideDefinitions:
@@ -139,28 +141,34 @@ def build_test_list():
139141
"Checkpoint Integration Test - Save Model Weights Only bf16",
140142
"model_weights_only_bf16",
141143
),
142-
OverrideDefinitions(
143-
[
144-
[
145-
"--parallelism.pipeline_parallel_degree 4",
146-
"--parallelism.pipeline_parallel_schedule InterleavedZeroBubble",
144+
]
145+
# check test_with_rocm
146+
if test_with_rocm != "1":
147+
integration_tests_flavors["debug_model.toml"].extend([
148+
OverrideDefinitions(
149+
[
150+
[
151+
"--parallelism.pipeline_parallel_degree 4",
152+
"--parallelism.pipeline_parallel_schedule InterleavedZeroBubble",
153+
],
147154
],
148-
],
149-
"PP looped zero bubble test",
150-
"pp_looped_zero_bubble",
151-
ngpu=4,
152-
),
153-
OverrideDefinitions(
154-
[
155-
[
156-
"--parallelism.pipeline_parallel_degree 2",
157-
"--parallelism.pipeline_parallel_schedule ZBVZeroBubble",
155+
"PP looped zero bubble test",
156+
"pp_looped_zero_bubble",
157+
ngpu=4,
158+
),
159+
OverrideDefinitions(
160+
[
161+
[
162+
"--parallelism.pipeline_parallel_degree 2",
163+
"--parallelism.pipeline_parallel_schedule ZBVZeroBubble",
164+
],
158165
],
159-
],
160-
"PP zero bubble test (v shaped)",
161-
"pp_zbv",
162-
ngpu=2,
163-
),
166+
"PP zero bubble test (v shaped)",
167+
"pp_zbv",
168+
ngpu=2,
169+
),
170+
])
171+
integration_tests_flavors["debug_model.toml"].extend([
164172
OverrideDefinitions(
165173
[
166174
[
@@ -272,18 +280,24 @@ def build_test_list():
272280
"pp_looped_1f1b",
273281
ngpu=4,
274282
),
275-
OverrideDefinitions(
276-
[
277-
[
278-
"--parallelism.pipeline_parallel_degree 2",
279-
"--parallelism.pipeline_parallel_schedule PipelineScheduleMulti",
280-
"--parallelism.pipeline_parallel_schedule_csv ./tests/assets/custom_schedule.csv",
283+
])
284+
# check test_with_rocm
285+
if test_with_rocm != "1":
286+
integration_tests_flavors["debug_model.toml"].extend(
287+
OverrideDefinitions(
288+
[
289+
[
290+
"--parallelism.pipeline_parallel_degree 2",
291+
"--parallelism.pipeline_parallel_schedule PipelineScheduleMulti",
292+
"--parallelism.pipeline_parallel_schedule_csv ./tests/assets/custom_schedule.csv",
293+
],
281294
],
282-
],
283-
"PP with custom pipeline schedule loaded from CSV file",
284-
"pp_custom_csv",
285-
ngpu=2,
286-
),
295+
"PP with custom pipeline schedule loaded from CSV file",
296+
"pp_custom_csv",
297+
ngpu=2,
298+
),
299+
)
300+
integration_tests_flavors["debug_model.toml"].extend([
287301
OverrideDefinitions(
288302
[
289303
[
@@ -494,7 +508,7 @@ def build_test_list():
494508
"Float8 emulation test",
495509
"float8_emulation",
496510
),
497-
]
511+
])
498512
return integration_tests_flavors
499513

500514

0 commit comments

Comments
 (0)