Skip to content

Revert "Make _get_program_from_buffer work for bundled programs" #14487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Revert "Make _get_program_from_buffer work for bundled programs" #14487

merged 1 commit into from
Sep 22, 2025

Conversation

kimishpatel
Copy link
Contributor

Reverts #14435

buf_len and some other variables unused related stuff is breaking a bunch of internal builds

@pytorch-bot pytorch-bot bot added the ci-no-td label Sep 22, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14487

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 109 Pending

As of commit 9259090 with merge base 42b33c0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kimishpatel kimishpatel merged commit c9f46e2 into main Sep 22, 2025
126 of 129 checks passed
@kimishpatel kimishpatel deleted the revert-14435-bundleio-fix branch September 22, 2025 21:19
mergennachin added a commit that referenced this pull request Sep 22, 2025
@mergennachin
Run selective build CI test with more restrictions
7b1a111 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
@mergennachin mergennachin mentioned this pull request Sep 22, 2025
Merged
@mergennachin
Copy link
Contributor

cc @Erik-Lundell @zingo

mergennachin added a commit that referenced this pull request Sep 22, 2025
@mergennachin
Run selective build CI test with more restrictions
0706036 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 22, 2025
@mergennachin
Run selective build CI test with more restrictions
49d5422 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 22, 2025
@mergennachin
Run selective build CI test with more restrictions
b05a588 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 22, 2025
@mergennachin
Run selective build CI test with more restrictions
040a594 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Run selective build CI test with more restrictions
8ab225a 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Run selective build CI test with more restrictions
bd69404 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Run selective build CI test with more restrictions
78b0e08 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Run selective build CI test with more restrictions
072cf1a 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Run selective build CI test with more restrictions
3a89108 
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@kimishpatel @StrycekSimon
Revert "Make _get_program_from_buffer work for bundled programs" (pyt…
19d58ea 
…orch#14487)

Reverts pytorch#14435

`buf_len` and some other variables unused related stuff is breaking a
bunch of internal builds
mergennachin added a commit that referenced this pull request Sep 23, 2025
@mergennachin
Shift Left: Run selective build CI test with more restrictions (#14488)
95888a4 
Revert reason for #14487 was
that internal tests were running with "-Werror,-Wunused-variable"
(https://www.internalfb.com/diff/D82981124) option but not OSS tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@kirklandsign kirklandsign Awaiting requested review from kirklandsign kirklandsign is a code owner

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

Assignees
No one assigned
Labels
ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimishpatel @mergennachin @JacobSzwejbka