Shift Left: Run selective build CI test with more restrictions #14488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14488
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 3a89108 with merge base c9f46e2 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
mergennachin
commented
Sep 22, 2025
codegen/tools/selective_build.cpp
Outdated
Comment on lines
191
to
192
| const std::string_view sv = buffer.cast<std::string_view>(); | ||
| void* buf_ptr = const_cast<void*>(static_cast<const void*>(sv.data())); |
There was a problem hiding this comment.
will remove this before merging.
mergennachin
changed the title
lucylq
approved these changes
Sep 22, 2025
mergennachin
force-pushed
the
fix_selective_build
branch
4 times, most recently
from
b05a588 to
040a594
Compare
mergennachin
force-pushed
the
fix_selective_build
branch
from
040a594 to
8ab225a
Compare
mergennachin
force-pushed
the
fix_selective_build
branch
3 times, most recently
from
78b0e08 to
072cf1a
Compare
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" option but not OSS tests
mergennachin
force-pushed
the
fix_selective_build
branch
from
072cf1a to
3a89108
Compare
mergennachin
added a commit
that referenced
this pull request
Sep 23, 2025
Summary: - Enable buck targets in OSS under codegen/tools/targets.bzl - Build all buck targets in OSS under codegen/tools/... (Can't test yet due to torch not available in OSS buck) - Run test_tools_selective_build.py in pytest - Building on top of #14488 Pull Request resolved: #14499 Reviewed By: lucylq Differential Revision: D83024265 Pulled By: mergennachin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert reason for #14487 was that internal tests were running with "-Werror,-Wunused-variable" (https://www.internalfb.com/diff/D82981124) option but not OSS tests