-
Notifications
You must be signed in to change notification settings - Fork 619
[ET-VK] 6/n Split dispatches between multiple command buffers. Repurpose submit_current_cmd_and_wait to wait based on input flag. #12529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/trivedivivek/126/base
Are you sure you want to change the base?
Conversation
…ose submit_current_cmd_and_wait to wait based on input flag. This diff makes changes to the `submit_current_cmd_and_wait` function in the `ComputeGraph` class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed to `submit_current_cmd` and now takes an additional `wait` parameter. If `wait` is `true`, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting. Differential Revision: [D78360042](https://our.internmc.facebook.com/intern/diff/D78360042/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12529
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit c103fd7 with merge base 4551a56 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ose submit_current_cmd_and_wait to wait based on input flag. This diff makes changes to the `submit_current_cmd_and_wait` function in the `ComputeGraph` class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed to `submit_current_cmd` and now takes an additional `wait` parameter. If `wait` is `true`, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting. Differential Revision: [D78360042](https://our.internmc.facebook.com/intern/diff/D78360042/) ghstack-source-id: 296443189 Pull Request resolved: #12529
This pull request was exported from Phabricator. Differential Revision: D78360042 |
…ers. Repurpose submit_current_cmd_and_wait to wait based on input flag." This diff makes changes to the `submit_current_cmd_and_wait` function in the `ComputeGraph` class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed to `submit_current_cmd` and now takes an additional `wait` parameter. If `wait` is `true`, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting. Differential Revision: [D78360042](https://our.internmc.facebook.com/intern/diff/D78360042/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D78360042 |
…ers. Repurpose submit_current_cmd_and_wait to wait based on input flag." This diff makes changes to the `submit_current_cmd_and_wait` function in the `ComputeGraph` class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed to `submit_current_cmd` and now takes an additional `wait` parameter. If `wait` is `true`, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting. Differential Revision: [D78360042](https://our.internmc.facebook.com/intern/diff/D78360042/) [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D78360042 |
Stack from ghstack (oldest at bottom):
This diff makes changes to the
submit_current_cmd_and_wait
function in theComputeGraph
class to repurpose it to wait for command buffer completion based on an input flag. The function is renamed tosubmit_current_cmd
and now takes an additionalwait
parameter. Ifwait
istrue
, the function submits the command buffer to the GPU and waits for its completion. Otherwise, it only submits the command buffer without waiting.Differential Revision: D78360042