[ET-VK] 3/n Split dispatches between multiple command buffers. Track previous semaphore in context. #12523
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous semaphore in context. This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
This was referenced Jul 15, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12523
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 PendingAs of commit a0acb3e with merge base 0012ffa ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
trivedivivek
added a commit
that referenced
this pull request
Jul 15, 2025
…previous semaphore in context. This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) ghstack-source-id: 296378668 Pull Request resolved: #12523
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
This was referenced Jul 15, 2025
trivedivivek
added
the
release notes: vulkan
…ers. Track previous semaphore in context." This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
…ers. Track previous semaphore in context." This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
SS-JIA
approved these changes
Jul 16, 2025
…ers. Track previous semaphore in context." This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
…ers. Track previous semaphore in context." This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
…ers. Track previous semaphore in context." This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context. A new member variable `prev_semaphore_` was added to the `Context` class. This variable is used to store the semaphore of the previously submitted command buffer. Differential Revision: [D78360037](https://our.internmc.facebook.com/intern/diff/D78360037/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D78360037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff is the third part of a series of diffs aiming to split dispatches between multiple command buffers. In this diff, we are tracking the previous semaphore in the context.
A new member variable
prev_semaphore_was added to theContextclass. This variable is used to store the semaphore of the previously submitted command buffer.Differential Revision: D78360037