-
Notifications
You must be signed in to change notification settings - Fork 620
Disable FLAT_TENSOR when not used #12514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12514
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New Failures, 149 PendingAs of commit 6882273 with merge base 988435d ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
looks like lots of tests are saying TRAINING requires FLAT_TENSOR? https://github.com/pytorch/executorch/actions/runs/16303931818/job/46045288574#step:15:12001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back to your queue; since it's a build change and it breaks builds I can't just stamp it
92a0483
to
195c202
Compare
Rebase on: #12544, which removes pybind preset from linux preset. Previously seeing issues where:
|
195c202
to
6882273
Compare
Abandoning this PR. flat_tensor is required by extension_module for the program-data separation features we added: executorch/extension/module/CMakeLists.txt Lines 30 to 33 in 988435d
|
See: #12393
With the cmake refactor/migration to presets (see #11457), FLAT_TENSOR was enabled wherever EXTENSION_MODULE was enabled. It's not required for most targets (should just be training and tests for now), so removing it and the rule that EXTENSION_MODULE depends on it.
Rebase on: #12544