Skip to content

Disable FLAT_TENSOR when not used #12514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jul 15, 2025

See: #12393

With the cmake refactor/migration to presets (see #11457), FLAT_TENSOR was enabled wherever EXTENSION_MODULE was enabled. It's not required for most targets (should just be training and tests for now), so removing it and the rule that EXTENSION_MODULE depends on it.

Rebase on: #12544

Copy link

pytorch-bot bot commented Jul 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12514

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 149 Pending

As of commit 6882273 with merge base 988435d (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 15, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
Copy link
Contributor

looks like lots of tests are saying TRAINING requires FLAT_TENSOR? https://github.com/pytorch/executorch/actions/runs/16303931818/job/46045288574#step:15:12001

Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to your queue; since it's a build change and it breaks builds I can't just stamp it

@lucylq lucylq force-pushed the lfq.disable-flat-tensor-when-not-used branch 6 times, most recently from 92a0483 to 195c202 Compare July 16, 2025 18:59
@lucylq lucylq requested a review from jathu July 16, 2025 19:03
@lucylq
Copy link
Contributor Author

lucylq commented Jul 16, 2025

Rebase on: #12544, which removes pybind preset from linux preset.

Previously seeing issues where:

  • pybind preset turns FLAT_TENSOR on for training.
  • llm preset turns FLAT_TENSOR off as it's not needed.

@lucylq lucylq force-pushed the lfq.disable-flat-tensor-when-not-used branch from 195c202 to 6882273 Compare July 16, 2025 21:51
@lucylq
Copy link
Contributor Author

lucylq commented Jul 16, 2025

Abandoning this PR. flat_tensor is required by extension_module for the program-data separation features we added:

target_link_libraries(
extension_module PRIVATE executorch_core extension_data_loader
extension_flat_tensor
)

@lucylq lucylq closed this Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants