-
Notifications
You must be signed in to change notification settings - Fork 622
Update examples/models/llama/README.md to fix build broken #12393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jie Fu <[email protected]>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12393
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit efbf137 with merge base a0618c8 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Hi @DamonFool, thanks for submitting this PR. I don't think llama build should require |
Thanks @lucylq for taking a look at this. The logic is that llama requires EXECUTORCH_BUILD_EXTENSION_MODULE, which requires EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR. The cmake error msg has showed that dependency clearly. |
Hi @lucylq , After #11457 , |
Hi @DamonFool , thank you for the PR link! I added #12514 to remove FLAT_TENSOR when it's not needed. I think that was added in to ensure all the builds work when we were adding cmake presets; it should be removed now that things are more stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR @DamonFool.
I was mistaken, and flat_tensor is required as a dependency of extension_module.
Thanks @lucylq . |
Hi @lucylq , are you fine to merge this pr? |
Fix the following error ``` CMake Error at tools/cmake/common/preset.cmake:122 (message): Use of 'EXECUTORCH_BUILD_EXTENSION_MODULE' requires 'EXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR' Call Stack (most recent call first): tools/cmake/preset/default.cmake:300 (check_required_options_on) CMakeLists.txt:87 (include) ``` Signed-off-by: Jie Fu <[email protected]>
Thanks @lucylq . |
Fix the following error