Update flat tensor ndm to account for named delegate data #10330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO: consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Currently, we assume that a PTD file has either tensors or named_data, not both. After the consolidation, this won't be an issue. Differential Revision: [D73380805](https://our.internmc.facebook.com/intern/diff/D73380805/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10330
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 6 New Failures, 1 Unrelated FailureAs of commit ad715d9 with merge base 06f912d ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 21, 2025
facebook-github-bot
added
the
CLA Signed
lucylq
added a commit
that referenced
this pull request
Apr 21, 2025
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions. Add support to return named_data values as well. TODO: consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code. Currently, we assume that a PTD file has either tensors or named_data, not both. After the consolidation, this won't be an issue. Differential Revision: [D73380805](https://our.internmc.facebook.com/intern/diff/D73380805/) ghstack-source-id: 279349252 Pull Request resolved: #10330
|
This pull request was exported from Phabricator. Differential Revision: D73380805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently flat_tensor ndm only accounts for tensors in get_data, get_num_keys, get_key functions.
Add support to return named_data values as well.
TODO: consolidate tensors and named_data into one structure in the flatbuffer. This will simplify all the serialization and runtime code.
Currently, we assume that a PTD file has either tensors or named_data, not both. After the consolidation, this won't be an issue.
Differential Revision: D73380805