Serialize PTD files with named data #10327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For external files we only take items from the emitter; should take from emitter + named_data from the named data store. Differential Revision: [D73281886](https://our.internmc.facebook.com/intern/diff/D73281886/) [ghstack-poisoned]
lucylq
requested review from
JacobSzwejbka,
tarun292 and
larryliu0820
as code owners
This was referenced Apr 21, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10327
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 1 Unrelated FailureAs of commit 729ddad with merge base 06f912d ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
lucylq
added a commit
that referenced
this pull request
Apr 21, 2025
For external files we only take items from the emitter; should take from emitter + named_data from the named data store. Differential Revision: [D73281886](https://our.internmc.facebook.com/intern/diff/D73281886/) ghstack-source-id: 279346388 Pull Request resolved: #10327
|
This pull request was exported from Phabricator. Differential Revision: D73281886 |
This was referenced Apr 21, 2025
mcr229
approved these changes
Apr 21, 2025
facebook-github-bot
merged commit 8c874e6
into
gh/lucylq/62/base
83 of 89 checks passed
facebook-github-bot
had a problem deploying
to
cherry-pick-bot
GitHub Actions
Failure
lucylq
added a commit
that referenced
this pull request
Apr 22, 2025
For external files we only take items from the emitter; should take from emitter + named_data from the named data store. Differential Revision: [D73281886](https://our.internmc.facebook.com/intern/diff/D73281886/) ghstack-source-id: 279346388 Pull Request resolved: #10327
lucylq
added a commit
that referenced
this pull request
Apr 22, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #10327 by @lucylq ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/62/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/62/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/61/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/62/orig @diff-train-skip-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For external files we only take items from the emitter; should take from emitter + named_data from the named data store.
Differential Revision: D73281886