-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-93096: Update and document pickle
CLI
#131097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cc @picnixz
Co-authored-by: Bénédikt Tran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit and LGTM.
pickle
pickle
pickle
pickle
CLI
Co-authored-by: Bénédikt Tran <[email protected]>
I'll wait for Hugo's review and then we can probably merge it (just for a last checkup) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Do we need a NEWS file? This started out as docs only, but we're changing the code in |
We changed the code but it was already not documented. I don't think it's worth a What's New entry, but a small NEWS entry may be nice. We could make it under Library to mention that we now use |
Please don't replace pprint.pprint() with pprint.pp() in this PR but write a separated change for that. |
Ok, I reverted using |
Thanks, remember to push :) |
Co-authored-by: Hugo van Kemenade <[email protected]>
Merged, thank you. |
Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
updated preview:

📚 Documentation preview 📚: https://cpython-previews--131097.org.readthedocs.build/en/131097/library/pickle.html#command-line-interface