-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Using MANIFEST.in" guide, moved to setuptools docs #1377
Conversation
The setuptools PR has been merged, so this is now ready. |
I was wondering if it would be possible to add a HTTP redirect instead of removing1... This way any existing links in places other than the setuptools docs themselves (thanks Jean) would still "work". In setuptools, I use sphinx-reredirects in a couple of places to achieve something similar. Footnotes
|
@abravalheri This is what I wrote in the PR description:
The PUG uses redirects configured from the RTD Web UI instead of sphinx-reredirects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we have been creating orphan stubs instead of completely removing docs.
Why? Seems like we are locking ourselves to RTD for no reason. I asked on some other thread but it might be a bit hidden, forgive me for asking again... |
You are right, I was already forgetting about @pradyunsg's concerns on redirecting to a different domain (at least as long as documatt/sphinx-reredirects#6 isn't merged). |
Fixed. Sorry for the misstep. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @jeanas.
@sinoroc I think @pradyunsg would be better to respond to your question. |
Filed #1408 which, I think makes it easier to track the RtD redirects if we're going to be adding them for anything or already have a bunch. |
This page: https://packaging.python.org/en/latest/guides/using-manifest-in/ is very setuptools-specific, describing the syntax of setuptools'
MANIFEST.in
file. I think the setuptools documentation is a better home for this. I've opened a PR on the setuptools repo to add it. Once it's merged, this PR can be undrafted and merged. It removes the document, which should be replaced by a redirect in the ReadTheDocs configuration.📚 Documentation preview 📚: https://python-packaging-user-guide--1377.org.readthedocs.build/en/1377/