-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide how to images for projects; screenshots; logos; guides; gifs; videos #1110
Comments
@illume Can you elaborate please? |
Maybe you mean how to add "package data" (non Python files) to the distributions so that they get installed? If yes, then I agree it would be good to have such a guide and/or tutorial. |
Ah, maybe. But then, this is really dependent on the build backend. I think this should be left to individual backend docs since it will tend to get outdated if it's not maintained by the same people as the backends. See also #1377. |
I think we should have at least a page explaining the non-tool specific principles of solving this common problem. Some ideas:
Probably it should be a discussion (not a tutorial or a guide). |
Ok, good idea.
A tricky question since there is, AFAIK, no consensus on that. https://discuss.python.org/t/should-sdists-include-docs-and-tests/14578 https://discuss.python.org/t/sdists-for-pure-python-projects/25191/39 |
People often use images videos and such in their project descriptions. For screenshots, for guides, and various other things. How should these be included? |
You'd put the image in some permanent location, e.g., inside your repository, and link it with standard Markdown or reST syntax in your |
I would rather use paths relative to the location of the README file. For example But @illume, that is not specific to Python or Python packaging. |
What works on Pypi? At some point it was filtering out external links. Not sure about now. Not sure where or if this is specified anywhere. |
Ah right... PyPI... I do not know. I guess there you can not use relative paths for images. The solution is probably to use public URLs. Personally I believe READMEs should contain only text. If I were to want to show screenshots, then I would put these screenshots on a separate website (something like Sphinx-built GitHub/GitLab pages or ReadTheDocs), and put a link to this website in the README. Then all the sources to build the website would be in the |
I just did a test here: https://test.pypi.org/project/readme-rendering-test-jeanas/ Package source: readme-rendering-test-jeanas.zip It appears that:
So, it's like I said: you should use an external URL. You can also look at the project page of PDM as an example. Source here |
It can be quite useful though, e.g., to quickly understand what a project does without having to click another link. Some projects like GUIs can be difficult to give an idea of in words only. |
That is useful info. It could be added to https://packaging.python.org/en/latest/guides/making-a-pypi-friendly-readme/ |
Good research! I was pretty sure it blocked external images at one point (maybe even when I opened this issue a couple of years ago). But you're right it does appear they are working. I guess this is privacy violation for pypi? https://www.python.org/privacy/ Because anyone can put up a link to any image it seems (and therefore drop any type of cookie). Maybe it's blocking cookies somehow. I see github markdown does NOT support base64 encoded images in markdown github/markup#270 (and probably never will). So it probably makes sense for pypi to also not support it. There's an example README.rst here that uses images: https://pypi.org/project/pygame/ source |
Yes, that does seem the best place to put this information. Also some examples of badges and a logo. (in markdown and restructured text). |
... and such?
People often use images videos and such in their project descriptions. For screenshots, for guides, and various other things.
How should these be included?
The text was updated successfully, but these errors were encountered: