Skip to content

Issue 536 fix #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issue 536 fix #695

wants to merge 1 commit into from

Conversation

@tselepakis
Copy link
Contributor

@tselepakis tselepakis commented Oct 20, 2025 •
edited
Loading

Provide field metadata utility function to properly handle Annotated types.

The issue was mentioned here.

@hramezani hramezani requested a review from Viicos October 23, 2025 11:01
@tselepakis
Copy link
Contributor Author

tselepakis commented Oct 23, 2025 •
edited
Loading

@Viicos let's continue the discussion about this here if you like. I had a quick look on the tests and I wasn't able to find any relevant test that we have nested annotations with NoDecode. Although I understand your concern regarding nesting, I am not sure I can replicate the issue. Do we actually care about the underling structure? I think we only need to identify that this field should not be decoded.

I tried something like this and it seems to work.

IntOrStr = TypeAliasType('IntOrStr', int | str)
A = TypeAliasType('A', Annotated[list[IntOrStr], NoDecode])

this also works

ListOrTuple = TypeAliasType('ListOrTuple', list[str] | tuple[str])
A = TypeAliasType('A', Annotated[ListOrTuple, NoDecode])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Viicos Viicos Awaiting requested review from Viicos

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tselepakis