Debian 11: Use correct package name for python bindings #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
alexjfisher,
deric and
ekohl
as code owners
bastelfreak
requested review from
SimonHoenscheid,
smortex and
a team
as code owners
|
This PR also contains #1645 , because the pipeline checks for outdated modules in metadata.json |
bastelfreak
force-pushed
the
debian11
branch
from
780d736 to
0e2aa93
Compare
Since Debian 11 was added to this module, the package name was wrong. It was set to python-psycopg2, but the correct name is python3-psycopg2. There's a longer analysis about this bug in https://github.com/puppetlabs/puppetlabs-postgresql/pull/1638/files#r2390588710 tl;dr: * Debian 10 used python-psycopg2 and that was set by the module * Debian 11 was added without proper acceptance testing * Later on unit tests were added for Debian 11, but still with the wrong package name * 651c2b4 fixed the package name, but in the wrong place and didn't adjust the tests * That resulted in a broken pipeline, that's how I found all of this This patch: * Cleans up the hiera data * sets the package name at the correct location * adjusts the debian 11 unit test for the new package name * Adds tests for Debian 12 and 13 (won't be executed right now because Perforce ships a too old version of FacterDB) Edit: Had to remove Debian 13 because the pipeline fails if it cannot find a factset.
bastelfreak
force-pushed
the
debian11
branch
from
0e2aa93 to
45d8a9d
Compare
deric
approved these changes
Sep 30, 2025
|
The acceptance tests are a mess, due to the broken pipeline. The adjusted unit tests pass now again, so I'm going to merge it. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Debian 11 was added to this module, the package name was wrong. It
was set to python-psycopg2, but the correct name is python3-psycopg2.
There's a longer analysis about this bug in https://github.com/puppetlabs/puppetlabs-postgresql/pull/1638/files#r2390588710
tl;dr:
package name
in the wrong place and didn't adjust the tests
This patch:
Edit: Had to remove Debian 13 because the pipeline fails if it cannot find a factset.