-
Notifications
You must be signed in to change notification settings - Fork 611
(CAT-2385) Puppetcore update #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
940e023
to
d8dd30d
Compare
@shubhamshinde360 can you please rebase? The unit tests were fixed in #1647 |
.fixtures.yml
Outdated
systemd: "https://github.com/voxpupuli/puppet-systemd.git" | ||
systemd: | ||
repo: "https://github.com/voxpupuli/puppet-systemd.git" | ||
ref: 8.3.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to pin the module
.fixtures.yml
Outdated
apt: "https://github.com/puppetlabs/puppetlabs-apt.git" | ||
apt: | ||
repo: 'https://github.com/puppetlabs/puppetlabs-apt.git' | ||
ref: v10.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to pin the module
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do lint for ruby 3.1 as a target, so everything will fail on ruby 3.0 anyways and the condition isn't required?
gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
gem "racc", '~> 1.4.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup)) | ||
gem "deep_merge", '~> 1.2.2', require: false | ||
gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
voxpupuli-puppet-lint-plugins, facterdb and rspec-puppet-facts are quite outdated, even after your changes. Are there plans to switch to newer versions?
d8dd30d
to
eba9dd2
Compare
Summary
Puppetcore update
Checklist
puppet apply
)