Skip to content

Conversation

shubhamshinde360
Copy link
Contributor

Summary

Puppetcore update

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@shubhamshinde360 shubhamshinde360 force-pushed the CAT-2385 branch 2 times, most recently from 940e023 to d8dd30d Compare September 29, 2025 14:38
@bastelfreak
Copy link
Collaborator

@shubhamshinde360 can you please rebase? The unit tests were fixed in #1647

.fixtures.yml Outdated
systemd: "https://github.com/voxpupuli/puppet-systemd.git"
systemd:
repo: "https://github.com/voxpupuli/puppet-systemd.git"
ref: 8.3.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to pin the module

.fixtures.yml Outdated
apt: "https://github.com/puppetlabs/puppetlabs-apt.git"
apt:
repo: 'https://github.com/puppetlabs/puppetlabs-apt.git'
ref: v10.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to pin the module

gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you do lint for ruby 3.1 as a target, so everything will fail on ruby 3.0 anyways and the condition isn't required?

gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "racc", '~> 1.4.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "deep_merge", '~> 1.2.2', require: false
gem "voxpupuli-puppet-lint-plugins", '~> 5.0', require: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voxpupuli-puppet-lint-plugins, facterdb and rspec-puppet-facts are quite outdated, even after your changes. Are there plans to switch to newer versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants