-
Notifications
You must be signed in to change notification settings - Fork 130
Enable registry to source metadata from pulumi registry APIs #7057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Your site preview for commit 9b9e03b is ready! 🎉 http://registry--origin-pr-7057-9b9e03bb.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 058d69b is ready! 🎉 http://registry--origin-pr-7057-058d69bc.s3-website.us-west-2.amazonaws.com/registry. |
058d69b
to
ffecacb
Compare
Your site preview for commit ffecacb is ready! 🎉 http://registry--origin-pr-7057-ffecacb1.s3-website.us-west-2.amazonaws.com/registry. |
ffecacb
to
d14a56c
Compare
d14a56c
to
8f3c1b9
Compare
Your site preview for commit d14a56c is ready! 🎉 http://registry--origin-pr-7057-d14a56cb.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 8f3c1b9 is ready! 🎉 http://registry--origin-pr-7057-8f3c1b99.s3-website.us-west-2.amazonaws.com/registry. |
@sean1588 Can you sync with @iwahbe on how we plan to publish to the registry service? While your change adds the necessary bits to pull from the registry service, Ian is working on the publishing side (which will still be driven by |
Your site preview for commit 2d10a9d is ready! 🎉 http://registry--origin-pr-7057-2d10a9d4.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit dfffeb3 is ready! 🎉 http://registry--origin-pr-7057-dfffeb30.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 2fc5728 is ready! 🎉 http://registry--origin-pr-7057-2fc5728b.s3-website.us-west-2.amazonaws.com/registry. |
@iwahbe I have addressed your comments. |
36d273f
to
c317adf
Compare
Your site preview for commit c8245ab is ready! 🎉 http://registry--origin-pr-7057-c8245ab7.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 4df7085 is ready! 🎉 http://registry--origin-pr-7057-4df7085b.s3-website.us-west-2.amazonaws.com/registry. |
@iwahbe tests added! |
Your site preview for commit 02e8827 is ready! 🎉 http://registry--origin-pr-7057-02e88271.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 315dae9 is ready! 🎉 http://registry--origin-pr-7057-315dae9e.s3-website.us-west-2.amazonaws.com/registry. |
315dae9
to
de25c1d
Compare
Your site preview for commit de25c1d is ready! 🎉 http://registry--origin-pr-7057-de25c1d9.s3-website.us-west-2.amazonaws.com/registry. |
b912c0e
to
a472920
Compare
Your site preview for commit a472920 is ready! 🎉 http://registry--origin-pr-7057-a4729205.s3-website.us-west-2.amazonaws.com/registry. |
We should be able to run a live test of this now. The live registry should have all the providers. |
a472920
to
def4342
Compare
Your site preview for commit def4342 is ready! 🎉 http://registry--origin-pr-7057-def43427.s3-website.us-west-2.amazonaws.com/registry. |
def4342
to
e8dac29
Compare
Your site preview for commit e8dac29 is ready! 🎉 http://registry--origin-pr-7057-e8dac290.s3-website.us-west-2.amazonaws.com/registry. |
Enable registry to source metadata from registry APIs.
Part of: https://github.com/pulumi/pulumi-service/issues/26019
Enables resourcedocsgen to source metadata from package endpoints. Will follow up with pulling schema from endpoints once available.
This PR enables
resourcedocsgen
to pull package metadata from the registry apis instead of sourcing from the data files in the registry repo.There is a boolean flag,
--use-api
, I added to enable building from the APIs. By default it will continue to use the filesystem. This will allow us to rollback easily if needed. We can flip this and test it out once the registry service contains the packages. Currently I am seeing an empty list of packages being returned, so I am assuming this has yet to be done. So far I am "guessing" what would be returned just based on inspecting the code in pulumi service. We can wait to get this in until then.For right now, we should expect the same end result with these changes as it is still configured to use the metadata files on the file system. See previews for confirmation.