Skip to content

Commit de25c1d

Browse files
committed
fix test
remove test
1 parent 02e8827 commit de25c1d

File tree

1 file changed

+9
-23
lines changed

1 file changed

+9
-23
lines changed

tools/resourcedocsgen/pkg/registry/svc/metadata_test.go

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,16 @@ func TestFileSystemProvider(t *testing.T) {
170170
})
171171

172172
t.Run("invalid yaml", func(t *testing.T) {
173-
err := os.WriteFile(filepath.Join(packagesDir, "invalid.yaml"), []byte("invalid yaml: ]["), fs.ModePerm)
173+
t.Parallel()
174+
175+
invalidDir := t.TempDir()
176+
invalidPackagesDir := filepath.Join(invalidDir, "themes", "default", "data", "registry", "packages")
177+
require.NoError(t, os.MkdirAll(invalidPackagesDir, fs.ModePerm))
178+
179+
err := os.WriteFile(filepath.Join(invalidPackagesDir, "invalid.yaml"), []byte("invalid yaml: ]["), fs.ModePerm)
174180
require.NoError(t, err)
175181

176-
provider := NewFileSystemProvider(tmpDir)
182+
provider := NewFileSystemProvider(invalidDir)
177183
_, err = provider.GetPackageMetadata(context.Background(), "invalid")
178184
assert.Error(t, err)
179185
assert.Contains(t, err.Error(), "unmarshalling the metadata file")
@@ -356,27 +362,7 @@ func TestRegistryAPIProvider(t *testing.T) {
356362
assert.Len(t, got, 3)
357363
assert.Equal(t, []string{"aws-test", "azure-test", "gcp-test"}, []string{got[0].Name, got[1].Name, got[2].Name})
358364
})
359-
360-
t.Run("invalid json response", func(t *testing.T) {
361-
t.Parallel()
362-
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
363-
w.WriteHeader(http.StatusOK)
364-
_, err := w.Write([]byte("invalid json"))
365-
require.NoError(t, err)
366-
}))
367-
defer server.Close()
368-
369-
provider := &registryAPIProvider{
370-
apiURL: server.URL,
371-
client: http.DefaultClient,
372-
}
373-
374-
_, err := provider.ListPackageMetadata(context.Background())
375-
assert.Error(t, err)
376-
assert.Contains(t, err.Error(), "decoding API response")
377-
})
378-
379-
t.Run("500 server error", func(t *testing.T) {
365+
t.Run("server error", func(t *testing.T) {
380366
t.Parallel()
381367
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
382368
w.WriteHeader(http.StatusInternalServerError)

0 commit comments

Comments
 (0)