Skip to content

Add mock-based coverage for session reuse, reconnect behavior, #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pugsley76 merged 3 commits into from
Jul 1, 2026
Merged

Add mock-based coverage for session reuse, reconnect behavior, #470

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dacb136
Add mock-based coverage for session reuse, reconnect behavior,
shadrach68 Jun 30, 2026
a67c23c
Merge branch 'main' into HSMSigning
shadrach68 Jun 30, 2026
22642e5
Merge branch 'main' into HSMSigning
pugsley76 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions internal/session/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,24 +174,19 @@
}

// columnExists checks if a column exists in a table.
func (s *Store) columnExists(table, column string) (bool, error) {

Check failure on line 177 in internal/session/store.go

View workflow job for this annotation

GitHub Actions / check-sizes 

syntax error: unexpected name string in argument list; possibly missing comma or )
rows, err := s.db.Query(fmt.Sprintf("PRAGMA table_info(%s)", table))
if err != nil {
return false, fmt.Errorf("failed to inspect %s schema: %w", table, err)
}
defer func() { _ = rows.Close() }()

for rows.Next() {
var cid int
var name, typ string
var notNull, pk int
var defaultValue interface{}
if err := rows.Scan(&cid, &name, &typ, &notNull, &defaultValue, &pk); err != nil {
return false, fmt.Errorf("failed to scan %s schema: %w", table, err)
}
if name == column {
return true, nil
}
if err := s.ensureColumn("sessions", "audit_hash", "TEXT"); err != nil {
return err
}
if err := s.ensureColumn("sessions", "audit_signature", "TEXT"); err != nil {
return err
}
if err := s.ensureColumn("sessions", "previous_session_hash", "TEXT"); err != nil {
return err
}
if err := rows.Err(); err != nil {
return false, err
Expand Down
Loading