Add mock-based coverage for session reuse, reconnect behavior,#470
Merged
Conversation
and cleanup, and document the updated signer lifecycle
|
@shadrach68 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves PKCS#11/HSM audit signing by making session handling more robust and predictable. The signer now reuses initialized PKCS#11 sessions and cached key lookups across signing operations, retries once when a cached session becomes stale, and returns clearer validation and runtime error messages for common failure cases.
Changes
Validation
npm exec -- jest --runInBand tests/pkcs11Signer.test.ts tests/pkcs11Signer.signing.test.ts src/commands/__tests__/audit.sign.spec.tsAll 27 focused tests passed.