Skip to content

feat(protocol): improve protocol registration validation and error ha… #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pugsley76 merged 2 commits into from
Jul 1, 2026
Merged

feat(protocol): improve protocol registration validation and error ha… #467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea0ab9
feat(protocol): improve protocol registration validation and error ha…
Killerjunior Jun 30, 2026
38f9bf1
Merge branch 'main' into improve-protocol-registration-validation
pugsley76 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/protocolreg/registration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,17 @@ func NewRegistrar() (*Registrar, error) {
)
}

// Validate that the path is not a system-critical directory (e.g., root, /usr, /etc)
// which would indicate a misconfigured installation.
cleanPath := filepath.Clean(executablePath)
if cleanPath == "/" || cleanPath == "\\" {
return nil, fmt.Errorf(
"executable path %q resolves to a system root directory — this is not a valid binary location\n"+
" Fix: ensure glassbox is installed in a proper bin directory (e.g., ~/.local/bin or /usr/local/bin)",
executablePath,
)
}

if _, err := os.Stat(executablePath); err != nil {
return nil, fmt.Errorf(
"executable not found at %s: %w\n"+
Expand Down
Loading