feat(protocol): improve protocol registration validation and error ha…#467
Merged
pugsley76 merged 2 commits intoJul 1, 2026
Merged
Conversation
…ndling - Add validatePreRegistration() to catch invalid state before OS modifications - Reject empty/non-existent executable paths with actionable Fix: hints - Validate home directory accessibility before writing registration artefacts - Check executable permissions on Unix (reject non-executable binaries) - Reject system root paths (/ or \) as executable locations - Add post-write validation for Linux wrapper scripts and macOS plist files - Add cleanup on partial failure (remove wrapper/plist if desktop file write fails) - Make update-desktop-database failure non-fatal on Linux - Add comprehensive tests for all new validation paths - Update documentation to describe enhanced validation behavior
|
@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368