Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace load-generator with Go implementation #743

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,3 @@ updates:
patterns:
- "go.opentelemetry.io/*"
open-pull-requests-limit: 20
- package-ecosystem: "pip"
directory: "/tools/load-generator"
schedule:
interval: "monthly"
2 changes: 2 additions & 0 deletions .promu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ build:
path: ./tools/fake-webserver
- name: tools/scaler
path: ./tools/scaler
- name: tools/load-generator
path: ./tools/load-generator
flags: -a -tags netgo
crossbuild:
platforms:
Expand Down
19 changes: 19 additions & 0 deletions prombench/manifests/prombench/benchmark/6_loadgen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,25 @@ data:
- expr: histogram_quantile(0.99, sum by(path, le) (rate(codelab_api_request_duration_seconds_bucket{method="POST"}[5m])))
- expr: histogram_quantile(0.99, sum by(path, method, le) (rate(codelab_api_request_duration_seconds_bucket{method="POST"}[5m])))
- expr: histogram_quantile(0.99, sum by(instance, le) (rate(codelab_api_request_duration_seconds_bucket{method="POST"}[5m])))
- name: binary_arithmetic_operators
interval: 15s
type: instant
queries:
- expr: sum(node_memory_MemAvailable_bytes) / sum(node_memory_MemTotal_bytes)
- expr: rate(node_network_transmit_bytes_total[5m]) * 8
- expr: node_filesystem_avail_bytes / node_filesystem_size_bytes
- name: logical_operators
interval: 15s
type: instant
queries:
- expr: rate(node_cpu_seconds_total{mode="system"}[5m]) and rate(node_cpu_seconds_total{mode="user"}[5m])
- expr: node_filesystem_avail_bytes unless node_filesystem_size_bytes
- expr: rate(node_network_receive_bytes_total[5m]) or rate(node_network_transmit_bytes_total[5m])
- name: topk_example
interval: 15s
type: instant
queries:
- expr: topk(5, rate(http_requests_total[5m]))
Comment on lines +51 to +69
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full marks for including it in the description, but this should be a separate PR.
Indeed it already is - #723.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bboreham Hi Sir, I am the same person who has created that #723 PR. I was not able to do DCO sign off for some weird reason, so i created a Fresh PR, from my secondary account, as i told that, my university exams are going on till september end, so as soon as it will end, i will look up to both the PRs.
Hope you understand.❤️❤️

---
apiVersion: apps/v1
kind: Deployment
Expand Down
12 changes: 5 additions & 7 deletions tools/load-generator/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
FROM python:3
FROM quay.io/prometheus/busybox:latest
SuperQ marked this conversation as resolved.
Show resolved Hide resolved
LABEL maintainer="The Prometheus Authors <[email protected]>"

COPY ./requirements.txt /usr/src/app/
RUN pip install -r /usr/src/app/requirements.txt
COPY load-generator /bin/load-generator

COPY ./*.py /usr/src/app/
EXPOSE 8080

WORKDIR /usr/src/app

ENTRYPOINT ["python", "-u", "./main.py"]
ENTRYPOINT ["/bin/load-generator"]
236 changes: 236 additions & 0 deletions tools/load-generator/main.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,236 @@
// Copyright 2024 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package main

import (
"fmt"
"io"
"log"
"net/http"
"os"
"sync"
"time"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promhttp"
"gopkg.in/yaml.v2"
)

// Global variables and Prometheus metrics

const max404Errors = 30

var (
domainName = os.Getenv("DOMAIN_NAME")

queryDuration = prometheus.NewHistogramVec(
prometheus.HistogramOpts{
Namespace: "loadgen",
Name: "query_duration_seconds",
Help: "Query duration",
Buckets: prometheus.LinearBuckets(0.05, 0.1, 20),
},
[]string{"prometheus", "group", "expr", "type"},
)
queryCount = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: "loadgen",
Name: "queries_total",
Help: "Total amount of queries",
},
[]string{"prometheus", "group", "expr", "type"},
)
queryFailCount = prometheus.NewCounterVec(
prometheus.CounterOpts{
Namespace: "loadgen",
Name: "failed_queries_total",
Help: "Amount of failed queries",
},
[]string{"prometheus", "group", "expr", "type"},
)
)

// Querier struct and methods
type Querier struct {
target string
name string
groupID int
numberOfErrors int

interval time.Duration
queries []Query
qtype string
start time.Duration
end time.Duration
step string
url string
}

type Query struct {
Expr string `yaml:"expr"`
}

type QueryGroup struct {
Name string `yaml:"name"`
Interval string `yaml:"interval"`
Queries []Query `yaml:"queries"`
Type string `yaml:"type,omitempty"`
Start string `yaml:"start,omitempty"`
End string `yaml:"end,omitempty"`
Step string `yaml:"step,omitempty"`
}

func NewQuerier(groupID int, target, prNumber string, qg QueryGroup) *Querier {
qtype := qg.Type
if qtype == "" {
qtype = "instant"
}

start := durationSeconds(qg.Start)
end := durationSeconds(qg.End)

url := fmt.Sprintf("http://%s/%s/prometheus-%s/api/v1/query", domainName, prNumber, target)
if qtype == "range" {
url = fmt.Sprintf("http://%s/%s/prometheus-%s/api/v1/query_range", domainName, prNumber, target)
}

return &Querier{
target: target,
name: qg.Name,
groupID: groupID,
interval: durationSeconds(qg.Interval),
queries: qg.Queries,
qtype: qtype,
start: start,
end: end,
step: qg.Step,
url: url,
}
}

func (q *Querier) run(wg *sync.WaitGroup) {
defer wg.Done()
fmt.Printf("Running querier %s %s for %s\n", q.target, q.name, q.url)
time.Sleep(20 * time.Second)

for {
start := time.Now()

for _, query := range q.queries {
q.query(query.Expr)
}

wait := q.interval - time.Since(start)
if wait > 0 {
time.Sleep(wait)
}
}
}

func (q *Querier) query(expr string) {
queryCount.WithLabelValues(q.target, q.name, expr, q.qtype).Inc()
start := time.Now()

req, err := http.NewRequest("GET", q.url, nil)
if err != nil {
log.Printf("Error creating request: %v", err)
queryFailCount.WithLabelValues(q.target, q.name, expr, q.qtype).Inc()
return
}

qParams := req.URL.Query()
qParams.Set("query", expr)
if q.qtype == "range" {
qParams.Set("start", fmt.Sprintf("%d", int64(time.Now().Add(-q.start).Unix())))
qParams.Set("end", fmt.Sprintf("%d", int64(time.Now().Add(-q.end).Unix())))
qParams.Set("step", q.step)
}
req.URL.RawQuery = qParams.Encode()

resp, err := http.DefaultClient.Do(req)
if err != nil {
log.Printf("Error querying Prometheus: %v", err)
queryFailCount.WithLabelValues(q.target, q.name, expr, q.qtype).Inc()
return
}
defer resp.Body.Close()

duration := time.Since(start)
queryDuration.WithLabelValues(q.target, q.name, expr, q.qtype).Observe(duration.Seconds())

if resp.StatusCode == http.StatusNotFound {
log.Printf("WARNING: GroupID#%d: Querier returned 404 for Prometheus instance %s.", q.groupID, q.url)
q.numberOfErrors++
if q.numberOfErrors >= max404Errors {
log.Fatalf("ERROR: GroupID#%d: Querier returned 404 for Prometheus instance %s %d times.", q.groupID, q.url, max404Errors)
}
} else if resp.StatusCode != http.StatusOK {
log.Printf("WARNING: GroupID#%d: Querier returned %d for Prometheus instance %s.", q.groupID, resp.StatusCode, q.url)
} else {
body, _ := io.ReadAll(resp.Body)
log.Printf("GroupID#%d: query %s %s, status=%d, size=%d, duration=%.3f", q.groupID, q.target, expr, resp.StatusCode, len(body), duration.Seconds())
}
}

func durationSeconds(s string) time.Duration {
num := s[:len(s)-1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashes when s is empty.

value, err := time.ParseDuration(num + string(s[len(s)-1]))
if err != nil {
log.Fatalf("Invalid duration: %s", s)
}
return value
}

func main() {
if len(os.Args) < 3 {
fmt.Println("unexpected arguments")
fmt.Println("usage: <load_generator> <namespace> <pr_number>")
os.Exit(2)
}
prNumber := os.Args[2]

configFile, err := os.ReadFile("/etc/loadgen/config.yaml")
if err != nil {
log.Fatalf("Failed to load config: %v", err)
}

var config struct {
Querier struct {
Groups []QueryGroup `yaml:"groups"`
} `yaml:"querier"`
}
if err := yaml.Unmarshal(configFile, &config); err != nil {
log.Fatalf("Failed to parse config: %v", err)
}

fmt.Println("Loaded configuration")

var wg sync.WaitGroup

for i, group := range config.Querier.Groups {
wg.Add(1)
go NewQuerier(i, "pr", prNumber, group).run(&wg)
wg.Add(1)
go NewQuerier(i, "release", prNumber, group).run(&wg)
}

prometheus.MustRegister(queryDuration, queryCount, queryFailCount)
http.Handle("/metrics", promhttp.Handler())
go func() {
log.Println("Starting HTTP server on :8080")
log.Fatal(http.ListenAndServe(":8080", nil))
}()

wg.Wait()
}
Loading