Replace load-generator with Go implementation #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
requested changes
Sep 3, 2024
SuperQ
reviewed
Sep 3, 2024
Signed-off-by: Harshit Nagpal <[email protected]>
HarshitNagpal2901
force-pushed
the
main
branch
from
1cb917e
to
7a2f7c0
Compare
|
@SuperQ sir, PTAL |
SuperQ
reviewed
Sep 5, 2024
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Harshit Nagpal <[email protected]>
|
@SuperQ Sir, can u pls approve? |
bboreham
reviewed
Sep 19, 2024
Comment on lines
+51
to
+69
| - name: binary_arithmetic_operators | ||
| interval: 15s | ||
| type: instant | ||
| queries: | ||
| - expr: sum(node_memory_MemAvailable_bytes) / sum(node_memory_MemTotal_bytes) | ||
| - expr: rate(node_network_transmit_bytes_total[5m]) * 8 | ||
| - expr: node_filesystem_avail_bytes / node_filesystem_size_bytes | ||
| - name: logical_operators | ||
| interval: 15s | ||
| type: instant | ||
| queries: | ||
| - expr: rate(node_cpu_seconds_total{mode="system"}[5m]) and rate(node_cpu_seconds_total{mode="user"}[5m]) | ||
| - expr: node_filesystem_avail_bytes unless node_filesystem_size_bytes | ||
| - expr: rate(node_network_receive_bytes_total[5m]) or rate(node_network_transmit_bytes_total[5m]) | ||
| - name: topk_example | ||
| interval: 15s | ||
| type: instant | ||
| queries: | ||
| - expr: topk(5, rate(http_requests_total[5m])) |
There was a problem hiding this comment.
Full marks for including it in the description, but this should be a separate PR.
Indeed it already is - #723.
There was a problem hiding this comment.
@bboreham Hi Sir, I am the same person who has created that #723 PR. I was not able to do DCO sign off for some weird reason, so i created a Fresh PR, from my secondary account, as i told that, my university exams are going on till september end, so as soon as it will end, i will look up to both the PRs.
Hope you understand.❤️❤️
| } | ||
|
|
||
| func durationSeconds(s string) time.Duration { | ||
| num := s[:len(s)-1] |
|
I didn't want to push a commit to your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace python load-generator with a Go implementation.
Add additional PromQL tests.
Fixes #688
Fixes #705