Skip to content

Enabling notifications for external apps #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhuvaneshiva wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enabling notifications for external apps #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d412dcb
fix(phone): support notifications for external apps
Bhuvaneshiva Nov 15, 2025
67813d7
fix(notifications): remove debug console.log for app background color
Bhuvaneshiva Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/phone/src/common/hooks/useExternalApps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const useExternalAppsAction = () => {
const element = document.createElement('script');

element.src = url;
element.type = 'text/javascript';
element.type = 'module';
element.async = true;

document.head.appendChild(element);
Expand Down Expand Up @@ -95,7 +95,7 @@ const useExternalAppsAction = () => {

const configs = await Promise.all(
externalApps.map(async (appName) => {
return appAlreadyLoaded(appName) ?? await generateAppConfig(appName);
return appAlreadyLoaded(appName) ?? (await generateAppConfig(appName));
}),
);

Expand Down
8 changes: 7 additions & 1 deletion apps/phone/src/os/apps/hooks/useApps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,14 @@ import { SvgIconComponent } from '@mui/icons-material';
import { useTheme } from '@mui/material';
import { useSettingsValue } from '../../../apps/settings/hooks/useSettings';
import { IconSetObject } from '@typings/settings';
import { useRecoilValue } from 'recoil';
import { phoneState } from '@os/phone/hooks/state';

export const useApps = () => {
const { icons } = useNotifications();
const theme = useTheme();
const curIconSet = useSettingsValue().iconSet.value as IconSetObject;
const externalApps = useRecoilValue(phoneState.extApps);

const apps: IApp[] = useMemo(() => {
return APPS.map((app) => {
Expand Down Expand Up @@ -52,7 +55,10 @@ export const useApps = () => {
});
}, [icons, curIconSet, theme]);

const allApps = useMemo(() => [...apps], [apps]);
const allApps = useMemo(
() => [...apps, ...externalApps.filter((app) => app)],
[apps, externalApps],
);
const getApp = useCallback(
(id: string): IApp => {
return allApps.find((a) => a.id === id) || null;
Expand Down
2 changes: 0 additions & 2 deletions apps/phone/src/os/new-notifications/components/NotificationBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ const NotificationBase = forwardRef<HTMLDivElement, NotificationBaseProps>((prop
console.warn('App does not have a notification icon');
}

console.log("app bg", app.backgroundColor)

return (
<SnackbarContent
onClick={handleNotisClick}
Expand Down