Enabling notifications for external apps#1208
Open
Bhuvaneshiva wants to merge 2 commits intoproject-error:masterfrom
Open
Enabling notifications for external apps#1208Bhuvaneshiva wants to merge 2 commits intoproject-error:masterfrom
Bhuvaneshiva wants to merge 2 commits intoproject-error:masterfrom
Conversation
- Set script type to 'module' for ES6 external app loading - Include external apps in app registry for notification lookup Resolves notification creation failures for external apps
- Removed console.log("app bg", app.backgroundColor) from NotificationBase component
- This was causing unwanted console output during notification rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixed two issues preventing external apps from creating notifications:
Module Loading
App Registry Integration
Removed debug console.log for app background color
Changes:
This ensures external apps like npwd_qbx_garages can successfully create
notifications through the NPWD notification system.
Pull Request Checklist: