Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RMP] Update the logs produce by the reliable message manager #35649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[RMP] Update the logs produce by the reliable message manager #35649

wants to merge 2 commits into from
+59 −15

Conversation

vivien-apple
Copy link
Contributor

Problem

It is not obvious to know which values are used with RMP, both for the local RMP values and the remote values.

This PR updates the code such that:

  • Local RMP values sent when establishing a PASE or CASE session are logged
  • Values used when a message is transmitted or retransmitted are logged

For what it worth those logs has allowed me to find an issue (issue # to come)

@vivien-apple vivien-apple self-assigned this Sep 18, 2024
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@vivien-apple vivien-apple mentioned this pull request Sep 18, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

PR #35649: Size comparison from 2396bb4 to 54216ef

Full report (39 builds for linux, nrfconnect, stm32, telink, tizen)
platform target config section 2396bb42 54216ef change % change
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2772147 2773245 1098 0.0
RAM 128944 128944 0 0.0
all-clusters-app debug unknown 5456 5456 0 0.0
FLASH 6074318 6075416 1098 0.0
RAM 506928 506928 0 0.0
all-clusters-minimal-app debug unknown 5352 5352 0 0.0
FLASH 5407696 5408826 1130 0.0
RAM 240640 240640 0 0.0
bridge-app debug unknown 5336 5336 0 0.0
FLASH 4741208 4742370 1162 0.0
RAM 217840 217840 0 0.0
chip-tool debug unknown 5888 5888 0 0.0
FLASH 12540702 12541908 1206 0.0
RAM 554506 554506 0 0.0
chip-tool-ipv6only arm64 unknown 20320 20320 0 0.0
FLASH 11240596 11241652 1056 0.0
RAM 604560 604560 0 0.0
fabric-admin debug unknown 5720 5720 0 0.0
FLASH 10893843 10895113 1270 0.0
RAM 553546 553546 0 0.0
fabric-bridge-app debug unknown 4568 4568 0 0.0
FLASH 4563946 4565078 1132 0.0
RAM 204456 204456 0 0.0
lighting-app debug+rpc+ui unknown 5984 5984 0 0.0
FLASH 5677521 5678689 1168 0.0
RAM 228128 228128 0 0.0
lock-app debug unknown 5272 5272 0 0.0
FLASH 4790488 4791650 1162 0.0
RAM 203928 203928 0 0.0
ota-provider-app debug unknown 4648 4648 0 0.0
FLASH 4423674 4424836 1162 0.0
RAM 197632 197632 0 0.0
ota-requestor-app debug unknown 4584 4584 0 0.0
FLASH 4562420 4563582 1162 0.0
RAM 202200 202200 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3102941 3104077 1136 0.0
RAM 158712 158712 0 0.0
thermostat-no-ble arm64 unknown 9336 9336 0 0.0
FLASH 4334076 4335180 1104 0.0
RAM 242256 242256 0 0.0
tv-app debug unknown 5552 5552 0 0.0
FLASH 6019749 6021013 1264 0.0
RAM 580464 580464 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10747277 10748445 1168 0.0
RAM 642384 642384 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 912968 913536 568 0.1
RAM 142175 142175 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884748 884748 0 0.0
RAM 140314 140314 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846476 847044 568 0.1
RAM 141077 141077 0 0.0
stm32 light STM32WB5MM-DK FLASH 480576 481160 584 0.1
RAM 144668 144668 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621702 622160 458 0.1
RAM 50964 50964 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 686942 687400 458 0.1
RAM 148304 148304 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 779886 780344 458 0.1
RAM 110756 110756 0 0.0
bridge-app tlsr9258a FLASH 680722 681180 458 0.1
RAM 91620 91620 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621466 621924 458 0.1
RAM 50916 50916 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707372 707830 458 0.1
RAM 74256 74256 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624620 625078 458 0.1
RAM 144292 144292 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810028 810486 458 0.1
RAM 99424 99424 0 0.0
lock-app-dfu tlsr9528a FLASH 655218 655676 458 0.1
RAM 66976 66976 0 0.0
ota-requestor-app tlsr9258a FLASH 696698 697156 458 0.1
RAM 91212 91212 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633054 633512 458 0.1
RAM 55792 55792 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610244 610702 458 0.1
RAM 53036 53036 0 0.0
shell tlsr9518adk80d FLASH 467170 467592 422 0.1
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628430 628888 458 0.1
RAM 52636 52636 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652380 652838 458 0.1
RAM 56584 56584 0 0.0
thermostat tlsr9518adk80d FLASH 636974 637432 458 0.1
RAM 53428 53428 0 0.0
window-covering tlsr9118bdk40d FLASH 523150 523608 458 0.1
RAM 97268 97268 0 0.0
tizen all-clusters-app arm unknown 4852 4852 0 0.0
FLASH 1720668 1721628 960 0.1
RAM 88952 88952 0 0.0
chip-tool-ubsan arm unknown 10252 10252 0 0.0
FLASH 17317338 17319978 2640 0.0
RAM 7543536 7544384 848 0.0

@pullapprove pullapprove bot requested a review from jtov-sfy September 19, 2024 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

PR #35649: Size comparison from afb1a33 to 7779c86

Full report (39 builds for linux, nrfconnect, stm32, telink, tizen)
platform target config section afb1a33 7779c86 change % change
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2764229 2765327 1098 0.0
RAM 129424 129424 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6067718 6068816 1098 0.0
RAM 507360 507360 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5401050 5402180 1130 0.0
RAM 241136 241136 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4734606 4735768 1162 0.0
RAM 218304 218304 0 0.0
chip-tool debug unknown 5960 5960 0 0.0
FLASH 12545884 12547090 1206 0.0
RAM 555058 555058 0 0.0
chip-tool-ipv6only arm64 unknown 20424 20424 0 0.0
FLASH 11253520 11254592 1072 0.0
RAM 605288 605288 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 10904383 10905653 1270 0.0
RAM 554234 554234 0 0.0
fabric-bridge-app debug unknown 4640 4640 0 0.0
FLASH 4557266 4558398 1132 0.0
RAM 204888 204888 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5670849 5672001 1152 0.0
RAM 228560 228560 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4783810 4784972 1162 0.0
RAM 204376 204376 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4416994 4418156 1162 0.0
RAM 198112 198112 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4555742 4556904 1162 0.0
RAM 202680 202680 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3094925 3096077 1152 0.0
RAM 159184 159184 0 0.0
thermostat-no-ble arm64 unknown 9416 9416 0 0.0
FLASH 4337392 4338512 1120 0.0
RAM 242808 242808 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6012949 6014213 1264 0.0
RAM 580896 580896 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10739453 10740605 1152 0.0
RAM 642976 642976 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913308 913876 568 0.1
RAM 142199 142199 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 884992 884992 0 0.0
RAM 140338 140338 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 846820 847388 568 0.1
RAM 141093 141093 0 0.0
stm32 light STM32WB5MM-DK FLASH 480920 481504 584 0.1
RAM 144692 144692 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 621958 622416 458 0.1
RAM 50988 50988 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 687200 687658 458 0.1
RAM 148328 148328 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 780144 780602 458 0.1
RAM 110780 110780 0 0.0
bridge-app tlsr9258a FLASH 680980 681438 458 0.1
RAM 91644 91644 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621722 622180 458 0.1
RAM 50940 50940 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 707630 708088 458 0.1
RAM 74280 74280 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 624878 625336 458 0.1
RAM 144316 144316 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 810286 810744 458 0.1
RAM 99448 99448 0 0.0
lock-app-dfu tlsr9528a FLASH 655476 655934 458 0.1
RAM 67000 67000 0 0.0
ota-requestor-app tlsr9258a FLASH 696956 697414 458 0.1
RAM 91236 91236 0 0.0
pump-app-usb tlsr9518adk80d FLASH 633312 633770 458 0.1
RAM 55816 55816 0 0.0
pump-controller-app tlsr9518adk80d FLASH 610502 610960 458 0.1
RAM 53060 53060 0 0.0
shell tlsr9518adk80d FLASH 467192 467614 422 0.1
RAM 68668 68668 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 628688 629146 458 0.1
RAM 52660 52660 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 652638 653096 458 0.1
RAM 56608 56608 0 0.0
thermostat tlsr9518adk80d FLASH 637232 637690 458 0.1
RAM 53452 53452 0 0.0
window-covering tlsr9118bdk40d FLASH 523408 523866 458 0.1
RAM 97284 97284 0 0.0
tizen all-clusters-app arm unknown 4876 4876 0 0.0
FLASH 1721872 1722832 960 0.1
RAM 89084 89084 0 0.0
chip-tool-ubsan arm unknown 10312 10312 0 0.0
FLASH 17348306 17350946 2640 0.0
RAM 7558408 7559256 848 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

Assignees

@vivien-apple vivien-apple

Labels
messaging protocols review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vivien-apple