[DNS-SD] Common Resolution Data such as the idle interval, active int… #35650
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erval, etc... are ignored by the dnssd platform discovery code when a commissionable node is discovered
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
pidarped,
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
wiba-nordic,
woody-apple,
younghak-hwang and
yunhanw-google
bzbarsky-apple
approved these changes
Sep 18, 2024
jmartinez-silabs
approved these changes
Sep 18, 2024
|
PR #35650: Size comparison from 2396bb4 to 40ad4dd Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Sep 18, 2024
|
updated to latest |
|
PR #35650: Size comparison from 0d17a40 to e70b44b Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erval, etc... are ignored by the dnssd platform discovery code when a commissionable node is discovered
Problem
By altering the logs (#35649) used with the ReliableMessageMgr I found out that #33025 has regressed the discovery code such that the some of the values advertise by accessories are ignored.
The list of ignored values are:
Concretely it means the the PBKDFParamRequest use to establish a PASE session defaults to the default MRP values defined in the spec, not the one advertised by the accessory.