Skip to content

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sh1pt-actions-fleet wants to merge 1 commit into from
Closed

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0) #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Managed by sh1pt Actions Fleet
# pack: node-pnpm-test@1.0.0
# install: sh1pt-actions-store
# hash: sha256:14a3f6fdbc21be92e815a16317251c967e4fbd95a5daf98819e0c23e7d56bf4f
name: test

on:
pull_request:
push:
branches: [master]

permissions:
contents: read

jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v4
with:
version: 9.12.0
Comment on lines +22 to +24

@greptile-apps greptile-apps Bot May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 pnpm version conflicts with engines constraint

package.json declares "pnpm": ">=10.0.0" in engines, but this workflow installs pnpm 9.12.0. Running pnpm install --frozen-lockfile with the wrong major version can fail outright if the lockfile format was updated for pnpm 10, or silently install a differently-resolved dependency graph than the one used locally — defeating the purpose of --frozen-lockfile.

Suggested change
- uses: pnpm/action-setup@v4
with:
version: 9.12.0
- uses: pnpm/action-setup@v4
with:
version: 10


- uses: actions/setup-node@v4
with:
node-version: 22
cache: pnpm

- run: pnpm install --frozen-lockfile

- run: pnpm test
env:
CI: true
Loading