sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0) - #107
sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0)#107sh1pt-actions-fleet[bot] wants to merge 1 commit into
Conversation
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
Greptile SummaryThis PR adds a generated GitHub Actions workflow (
Confidence Score: 3/5The workflow will likely fail on its first run due to the pnpm version mismatch with the project's declared requirements. The workflow pins pnpm to 9.12.0 while package.json requires pnpm >=10.0.0. The pnpm lockfile format changed between major versions, so pnpm install --frozen-lockfile will either error out on the lockfile format mismatch or install an inconsistent dependency tree, meaning the CI job will never produce a reliable green result as written. .github/workflows/test.yml — the pnpm version needs to be bumped to 10.x to match the project's engine constraint. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub Event
participant WF as test.yml Workflow
participant pnpm as pnpm@9.12.0
participant Node as Node.js 22
participant Tests as vitest run
GH->>WF: pull_request / push to master
WF->>Node: "actions/checkout@v4"
WF->>pnpm: "pnpm/action-setup@v4 (version: 9.12.0)"
Note over pnpm: ⚠️ package.json requires pnpm >=10.0.0
WF->>Node: "actions/setup-node@v4 (node: 22, cache: pnpm)"
WF->>pnpm: pnpm install --frozen-lockfile
pnpm-->>WF: may fail if lockfile format is pnpm 10+
WF->>Tests: "pnpm test (CI=true)"
Tests-->>WF: pass / fail
Reviews (1): Last reviewed commit: "Add .github/workflows/test.yml via sh1pt..." | Re-trigger Greptile |
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 9.12.0 |
There was a problem hiding this comment.
pnpm version conflicts with
engines constraint
package.json declares "pnpm": ">=10.0.0" in engines, but this workflow installs pnpm 9.12.0. Running pnpm install --frozen-lockfile with the wrong major version can fail outright if the lockfile format was updated for pnpm 10, or silently install a differently-resolved dependency graph than the one used locally — defeating the purpose of --frozen-lockfile.
| - uses: pnpm/action-setup@v4 | |
| with: | |
| version: 9.12.0 | |
| - uses: pnpm/action-setup@v4 | |
| with: | |
| version: 10 |
sh1pt Actions Fleet: install Node pnpm Test
Installs Node pnpm Test (
node-pnpm-test@1.0.0) from the sh1pt Actions Store.Files
.github/workflows/test.yml— createRequired secrets
No new secrets required.
Notes
Generated by sh1pt Actions Fleet.