Skip to content

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0) - #107

Closed
sh1pt-actions-fleet[bot] wants to merge 1 commit into
masterfrom
sh1pt/actions/node-pnpm-test/20260523-145125
Closed

sh1pt: install Node pnpm Test (node-pnpm-test@1.0.0)#107
sh1pt-actions-fleet[bot] wants to merge 1 commit into
masterfrom
sh1pt/actions/node-pnpm-test/20260523-145125

Conversation

@sh1pt-actions-fleet

Copy link
Copy Markdown
Contributor

sh1pt Actions Fleet: install Node pnpm Test

Installs Node pnpm Test (node-pnpm-test@1.0.0) from the sh1pt Actions Store.

Files

  • .github/workflows/test.yml — create

Required secrets

No new secrets required.

Notes

  • Generated workflow files include a managed comment with a sha256 of the rendered body, so future updates can be detected without overwriting hand-edits.
  • Install mode: pull request (no direct commits).
  • Rollback: close this PR or revert the merge commit.

Generated by sh1pt Actions Fleet.

@github-actions

Copy link
Copy Markdown

vu1nz Security Review

0 finding(s) in PR #?

No security issues found.

@ralyodio ralyodio closed this May 23, 2026
@greptile-apps

greptile-apps Bot commented May 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds a generated GitHub Actions workflow (.github/workflows/test.yml) that installs Node.js and pnpm, then runs pnpm test on pull requests and pushes to master.

  • The workflow is auto-generated by the sh1pt Actions Fleet tool using the node-pnpm-test@1.0.0 pack, with a managed SHA-256 hash comment for future update detection.
  • pnpm is pinned to 9.12.0, which conflicts with the project's package.json engines requirement of pnpm >=10.0.0, risking install failures or lockfile inconsistencies in CI.

Confidence Score: 3/5

The workflow will likely fail on its first run due to the pnpm version mismatch with the project's declared requirements.

The workflow pins pnpm to 9.12.0 while package.json requires pnpm >=10.0.0. The pnpm lockfile format changed between major versions, so pnpm install --frozen-lockfile will either error out on the lockfile format mismatch or install an inconsistent dependency tree, meaning the CI job will never produce a reliable green result as written.

.github/workflows/test.yml — the pnpm version needs to be bumped to 10.x to match the project's engine constraint.

Important Files Changed

Filename Overview
.github/workflows/test.yml New CI workflow for Node/pnpm tests; pins pnpm to 9.12.0 which conflicts with the project's declared engine requirement of pnpm >=10.0.0, likely causing install failures or lockfile mismatches.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Event
    participant WF as test.yml Workflow
    participant pnpm as pnpm@9.12.0
    participant Node as Node.js 22
    participant Tests as vitest run

    GH->>WF: pull_request / push to master
    WF->>Node: "actions/checkout@v4"
    WF->>pnpm: "pnpm/action-setup@v4 (version: 9.12.0)"
    Note over pnpm: ⚠️ package.json requires pnpm >=10.0.0
    WF->>Node: "actions/setup-node@v4 (node: 22, cache: pnpm)"
    WF->>pnpm: pnpm install --frozen-lockfile
    pnpm-->>WF: may fail if lockfile format is pnpm 10+
    WF->>Tests: "pnpm test (CI=true)"
    Tests-->>WF: pass / fail
Loading

Reviews (1): Last reviewed commit: "Add .github/workflows/test.yml via sh1pt..." | Re-trigger Greptile

Comment on lines +22 to +24
- uses: pnpm/action-setup@v4
with:
version: 9.12.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 pnpm version conflicts with engines constraint

package.json declares "pnpm": ">=10.0.0" in engines, but this workflow installs pnpm 9.12.0. Running pnpm install --frozen-lockfile with the wrong major version can fail outright if the lockfile format was updated for pnpm 10, or silently install a differently-resolved dependency graph than the one used locally — defeating the purpose of --frozen-lockfile.

Suggested change
- uses: pnpm/action-setup@v4
with:
version: 9.12.0
- uses: pnpm/action-setup@v4
with:
version: 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant